Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Conductor "Current" value is wrong in real-time mode #4350

Closed
akhenry opened this issue Oct 22, 2021 · 3 comments · Fixed by #6405
Closed

Time Conductor "Current" value is wrong in real-time mode #4350

akhenry opened this issue Oct 22, 2021 · 3 comments · Fixed by #6405
Assignees
Labels
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Oct 22, 2021

Is your feature request related to a problem? Please describe.
In real time mode the Time Conductor shows a time stamp labeled "Current" which is taken from the end time of the current time bounds. If the time conductor has end padding applied then it is not in fact the current time, it is some time in the future. The positioning of the end offset input further reinforces the idea that the timestamp shown is the current time, and that some padding is being applied in addition to to the current time, when this is not the case.

Screen Shot 2021-10-22 at 9 50 26 AM

In the example above the "Current" time is shown as 16:50:41.641Z, with an offset of 15s being applied. In fact the current time is 16:50:26.641Z, and a 15s padding is applied to that.

Describe the solution you'd like
Requires some design thinking. Do we want to show the actual "current" time, in which case we should change the value that's shown, or do we want to show the end bound (which includes padding), in which case we should change the label to something else. In the latter case we might consider changing the position of the label and the padding input.

Testing Instructions

  1. Switch to a realtime mode by changing Fixed Timespan in the time conductor to a clock
  2. Ensure the future padding (end offset) is greater than 0. It may help visual testing to increase the padding by an hour.
  3. Observe the Current Time as we'll be comparing it in the next step
  4. Switch the time mode back to Fixed Timespan
  5. Observe the End Time is not equal to the previous Current Time and that it is off by the padding previously set
@davetsay
Copy link
Contributor

@akhenry some deployments use Updated

@charlesh88 charlesh88 changed the title Time Conductor end time is ambiguous in real-time mode Time Conductor "Current" value is wrong in real-time mode Mar 1, 2023
@akhenry
Copy link
Contributor Author

akhenry commented Mar 6, 2023

The desired way to proceed is to keep the current label modify the logic so that it shows the current time, excluding the end padding (as opposed to its current behavior, where the end padding is included).

@akhenry
Copy link
Contributor Author

akhenry commented Mar 16, 2023

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants