cherry-pick(#6204): Fix multiple y axis issues #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure enabling log mode does not reset series that don't belong to that yaxis. propagate both left and right y axes widths so that plots can adjust accordingly * Revert code Handle second axis resizing * Fixes issue where logMode was getting initialized incorrectly for multiple y axes * Get the yAxisId of the series from the model. * Address review comments - rename params for readability * Fix number of log ticks expected and the tick values since we reduced the number of secondary ticks * Fix log plot test * Add guard code during destroy * Add missing remove callback
ozyx
changed the title
Codecov Report
@@ Coverage Diff @@
## release/2.1.6 #6253 +/- ##
================================================
Coverage ? 54.50%
================================================
Files ? 607
Lines ? 26076
Branches ? 2375
================================================
Hits ? 14213
Misses ? 11194
Partials ? 669
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
ozyx
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6166 #6147
Ensure enabling log mode does not reset series that don't belong to that yaxis. propagate both left and right y axes widths so that plots can adjust accordingly
Revert code Handle second axis resizing
Fixes issue where logMode was getting initialized incorrectly for multiple y axes
Get the yAxisId of the series from the model.
Address review comments - rename params for readability
Fix number of log ticks expected and the tick values since we reduced the number of secondary ticks
Fix log plot test
Add guard code during destroy
Add missing remove callback