Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stacked Plots] Plots are not lining up properly with Multiple Y Axes in Stacked Plots #6147

Closed
7 tasks
rukmini-bose opened this issue Jan 20, 2023 · 4 comments
Closed
7 tasks

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Jan 20, 2023

Summary

When an overlay plot with multiple y-axes is added to a stacked plot, plots do not line up anymore. In addition, the y-axes names and ticks are overlapping with each other.
213769962-25675524-ceac-4ffd-819e-796870c92e18

Expected vs Current Behavior

The x axes of plots within stacked plot objects should line up no matter the width of the y-axes. (AKA, if there exists a plot with multiple y-axes, ALL of the plots should adjust their widths to accommodate for this.
Screen Shot 2023-01-20 at 10 21 05 AM

Steps to Reproduce

  1. Create a stacked plot.
  2. Add an overlay plot with one axis, and another overlay plot with multiple axes (specifically, one where two axes populate the left side of the plot)
  3. Observe that the x axes for the plots do not line up anymore, since the y axis area for the plot with multiple y-axes is greater in width than the plot with only one axis.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Issue that came out of #6102

@charlesh88
Copy link
Contributor

This is actually a serious problem and IMO should be considered as data loss, in that the axis becomes unreadable and time on the X axis in the stacked children doesn't line up and is misleading:
Screen Shot 2023-01-24 at 2 23 01 PM

@shefalijoshi
Copy link
Contributor

Testing instructions:
Add a telemetry endpoint plot to a stacked plot
Create an overlay plot with one telemetry endpoint on yaxis 1, yaxis 2 and yaxis 3 each.
Add the overlay plot to the stacked plot.
Create another overlay plot with one telemetry endpoint on y axis 2 only
Ensure that the canvases for all plots line up correctly on the left and right.

@unlikelyzero
Copy link
Contributor

Verified fixed

@charlesh88
Copy link
Contributor

Verified fixed Testathon 2023-02-02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants