Misc UI fixes for release 2.0.8 #5684

charlesh88 · 2022-08-19T21:28:00Z

Closes #5640
Closes #5303

Describe your changes:

Better styling for search in progress and 'no results' messaging.
Revised art and glyph for icon-tabular-scrolling.
Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon.
Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set. Refined descriptions for other object types.
Fixed bad value check that was causing panes not to collapse when dragged (by design) to a very narrow width.
Visual style for grippy adjusted for better clarity on some monitors.
Normalize proportional area used by alphanumeric's labels and values in Display Layouts.
Fix margin strategy for object label in main view.
Fixed Locator to dynamically size itself to use available vertical space.
Added new l-overlay-dialog size parameter.
Better approach to overlay sizing to make Properties dialogs larger vertically and fullscreen overlays more apparent to the user.
Normalized approach to numeric inputs to fix cross-browser inconsistency with input spinners.
Fixed layout problem in Datetime.vue component due to numeric input spinners changes.
Added type definitions for Display Layout drawing objects; code modded in ObjectName.vue to grab layout object cssClass from layoutItem.type. Big thanks to @jvigliotta for the assist with this!

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Changes appear not to be breaking changes?
Appropriate unit tests included?
Code style and in-line documentation are appropriate?
Commit messages meet standards?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

* Add an active class to thumbnail to indicate current focused image * Differentiate bg color between real-time and fixed * scrollIntoView inline: center * Added watcher for bounds change to trigger thumbnail scroll * Resolve merge conflict with requestHistory change to telemetry collection * Split thumbnail into sub component * Monitor isFixed value to unpause playback status Co-authored-by: Khalid Adil <[email protected]>

* update selectors to use aria labels * Update appActions - Create new function `getHashUrlToDomainObject` to get the browse url to a given object given its uuid - Create new function `getFocusedObjectUuid`... self explanatory :) - Update `createDomainObjectWIthDefaults` to make use of the new url generation - Update `createDomainObject...`'s arguments to be more organized, and accept a parent object - Update some docs, still need to clarify some * Update appActions e2e tests - Refactor for organization - Test our new appActions in one go * Update existing usages of `createDomainObject...` to match the new API * fix accidental renamed export * Fix jsdoc return types * refactor telemetryTable test to use appActions * Improve selectors * Refactor test * improve selector * add clock mode appActions * lint * Fix jsdoc * Code review comments * mark failing visual tests as fixme temporarily

… object (#5604)

…aned results (#5599) * no matching result implemented * now filtering annotations that are orphaned * filter object results without valid paths * add progress bar * added e2e tests * removed extraneous click * fix typos * fix unit tests * lint * address pr comments * fix tests * fix tests, centralize logic to object api, check for root instead * remove debug statement * lint * fix documentation * lint * fix doc * made some optimizations after talking with akhenry * fix test * update docs * fix docs

* need to remove tags and objects on composition removal * had to separate out emits from load as it was causing memory indexer to loop upon itself

* Add parsing util to identifier for ID comparison * Moved firstIdentifier to top of function * Lint fix Co-authored-by: Andrew Henry <[email protected]>

…5609) This reverts commit 7cf11e1.

* check for circular references * add test * fix test * address PR comments by making comments better * fix docs...again

* do not create circular refs * add negative validation test * move to plugin * add link test too * fix docs * refactored per john request * fix path * use appAction lib Co-authored-by: Jesse Mazzella <[email protected]>

* added unit tests for fault management plugin * modified the example fault provider to work out of the box * updating for new e2e folder structure * part of the e2e tests * WIP * Imagery thumbnail regression fixes - 5327 (#5569) * Add an active class to thumbnail to indicate current focused image * Differentiate bg color between real-time and fixed * scrollIntoView inline: center * Added watcher for bounds change to trigger thumbnail scroll * Resolve merge conflict with requestHistory change to telemetry collection * Split thumbnail into sub component * Monitor isFixed value to unpause playback status * updated search to include name, namespace and description added some more e2e tests * added rest of e2e tests * fixed my init script, had to disable lint for no-force because it was not working without it, saw online this may be a pw bug * fix: removing maelstrom theme from application (#5600) * added some tests for no faults * visual tests * added visual tests for fault management * created utils file for shared functionality between function and visual tests * updating to 2.0.8 * tryin to remove imagery changes from master * trying to trigger a refresh * tryin to refresh * updated search to include name, namespace and description added some more e2e tests * added rest of e2e tests * fix: removing maelstrom theme from application (#5600) * fixed my init script, had to disable lint for no-force because it was not working without it, saw online this may be a pw bug * added some tests for no faults * visual tests * added visual tests for fault management * created utils file for shared functionality between function and visual tests * updating to 2.0.8 * no clue * still no clue * removing imports and chaning to requires * updating utils file to work with require * fixing paths * fixing a test I had messed up when adding static exmaple faults * ONE LAST PATH FIX... hopefully * typo in files fix * fix folder typo * thought I got this one, but apparently not, well I did now! who is laughing now!? Co-authored-by: Michael Rogers <[email protected]> Co-authored-by: Vitor Henckel <[email protected]>

* fix typo * Sort the tree items locally on object rename * Use the navigationPath as a key - This ensures that objects AND linked objects will be sorted * add 'tree' and 'treeitem' roles to mct-tree * WIP tree item reordering test * Select the first object that matches * Test that all object links are also reordered * Get the final uuid before queryParams as notebook sections have uuids * Make `openObjectTreeContextMenu` more deterministic and update usage * Add `expandPathToTreeItem` and `expandTreeItemByName` appActions * add `#tree-pane` id for the tree view * Add tree visual component test suite and bump percy-cli * Remove tree appActions * Better variable name Co-authored-by: Scott Bell <[email protected]>

- Layout frame edit handle visually tweaked, no longer resizes frame contents on hover when editing. - Gauge now centers in its container instead of left flush. - Added large bg-icon for aggregate telemetry.

- Removed 'no class' single wrapper div in mct-tree.vue. - Refinements to appearance of locator in save/edit overlay dialog.

- Better styling for search in progress and 'no results' messaging.

- Revised art and glyph for `icon-tabular-scrolling`. - Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon. - Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set.

- Fix descriptions for multiple view types.

- Removed unused .bg-icon class.

LGTM

- Fixed bad value check that was causing panes not to collapse when dragged (by design) to a very narrow width.

- Visual style for grippy adjusted for better clarity on some monitors.

- Normalize size of alphanumeric's labels and values in Display Layouts. - Fix margin strategy for object label in main view.

* Use more deterministic selector * Hover first to "slow down" e2e actions while in headless mode

- Fixed Locator to dynamically size itself to use available vertical space.

- Added new `l-overlay-dialog` size parameter. - Better approach to overlay sizing to make Properties dialogs larger vertically and fullscreen overlays more apparent to the user.

- Normalized approach to numeric inputs to fix cross-browser inconsistency with input spinners. - Fixed layout problem in `Datetime.vue` component due to numeric input spinners changes.

…- 5632 (#5664) * Set focused image when timestamp prop is passed in * Unused var * Create timestrip with imagery child * Add equality check for hovered image and view large image url * Cleanup

* Changes to Time List view. Closes #5534. - Compacted table row spacing. - Set all timeframes to display by default when creating a new Time List. - Removed 'Upload plan' file button from properties. * Changes to Time List view. Closes #5534. - Better hint text for editing Timeframe Inspector section. Co-authored-by: Andrew Henry <[email protected]>

…sc-ui-5640-r208

codecov · 2022-08-19T21:31:50Z

Codecov Report

❗ No coverage uploaded for pull request base (release/2.0.8@5386ceb). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.0.8    #5684   +/-   ##
================================================
  Coverage                 ?   54.10%           
================================================
  Files                    ?      597           
  Lines                    ?    22486           
  Branches                 ?     2057           
================================================
  Hits                     ?    12166           
  Misses                   ?     9734           
  Partials                 ?      586

Flag	Coverage Δ	*Carryforward flag
e2e-ci	`39.49% <0.00%> (?)`	Carriedforward from 6021664
e2e-full	`48.43% <0.00%> (?)`	Carriedforward from 6021664
e2e-stable	`46.15% <0.00%> (?)`
unit	`50.56% <0.00%> (?)`

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5386ceb...410755a. Read the comment docs.

@jvigliotta

- Added object types for Display Layout drawing objects. - Code modded in `ObjectName.vue` to grab layout object cssClass from layoutItem.type. - Big thanks to @jvigliotta for the assist with this!

cr4yfish

Glanced over it and looks good.
But I think you forgot to take out a console log. Tagged it.

src/plugins/displayLayout/plugin.js

…ed. (#5654) * Fix tests for interceptors * [e2e] Add test for 'mine' folder initialization * [e2e] don't fail on expected console errors Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: Scott Bell <[email protected]> Co-authored-by: John Hill <[email protected]> Co-authored-by: Jesse Mazzella <[email protected]>

* Update local CouchDB install docs to include docker workflow * reformat to source configuration scripts where possible * correct couchdb case Co-authored-by: John Hill <[email protected]>

* the check for fixed time vs realtime was not updating, have fixed this * merging in related changes from master pr #4414 * lint fixes * Update src/plugins/timeConductor/ConductorHistory.vue Co-authored-by: Jesse Mazzella <[email protected]> * setting time mode directly on load * fixing issue where realtime history was being wiped on reloads while viewing fixed time * formatting * stubbed in some tests Co-authored-by: Jesse Mazzella <[email protected]>

michaelrogers

These changes look good to me.

akhenry

Looks like there are changes from Master in here. Blocking until we can clean it up.

ozyx · 2022-08-24T18:15:50Z

Retargeted against master. This branch will need to be cherry-picked to get into a good state.

charlesh88 · 2022-08-24T18:33:24Z

Holding on this per request of @ozyx

michaelrogers and others added 30 commits August 2, 2022 13:44

Update package.json (#5601)

cb6014d

Fix menu style in Snow theme (#5557)

25de565

Include the plan source map when generating the time list/plan hybrid…

51d16f8

… object (#5604)

Have in-memory search indexer use composition API (#5578)

7cf11e1

* need to remove tags and objects on composition removal * had to separate out emits from load as it was causing memory indexer to loop upon itself

Add parsing for areIdsEqual util to consistently remove folders (#5589)

59a8614

* Add parsing util to identifier for ID comparison * Moved firstIdentifier to top of function * Lint fix Co-authored-by: Andrew Henry <[email protected]>

Revert "Have in-memory search indexer use composition API (#5578)" (#…

15a0a87

…5609) This reverts commit 7cf11e1.

[e2e] Tests for Display Layout and LAD Tables and telemetry (#5607)

c6c58af

Check for circular references in originalPath - 5615 (#5619)

41f8cb4

* check for circular references * add test * fix test * address PR comments by making comments better * fix docs...again

Update version number

5dc718b

Prevent cyclic references in link & move actions (#5635)

61bf607

* do not create circular refs * add negative validation test * move to plugin * add link test too * fix docs * refactored per john request * fix path * use appAction lib Co-authored-by: Jesse Mazzella <[email protected]>

Closes #5640

36b7b3b

- Layout frame edit handle visually tweaked, no longer resizes frame contents on hover when editing. - Gauge now centers in its container instead of left flush. - Added large bg-icon for aggregate telemetry.

Closes #5640

a6d026c

- Removed 'no class' single wrapper div in mct-tree.vue. - Refinements to appearance of locator in save/edit overlay dialog.

Closes #5640

a51c737

- Better styling for search in progress and 'no results' messaging.

Closes #5640

a04552c

- Revised art and glyph for `icon-tabular-scrolling`. - Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon. - Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set.

Closes #5640

536a63a

- Fix descriptions for multiple view types.

Closes #5640

b867158

- Removed unused .bg-icon class.

Mct5549 fix indexer composition error (#5610)

f721980

[Display Layout] Composition and configuration sync (#5669)

64565b1

LGTM

Closes #5640

f1c90b6

- Fixed bad value check that was causing panes not to collapse when dragged (by design) to a very narrow width.

Closes #5640

63149ec

- Visual style for grippy adjusted for better clarity on some monitors.

Closes #5640

976ea55

- Normalize size of alphanumeric's labels and values in Display Layouts. - Fix margin strategy for object label in main view.

[e2e] Stabilize notebook tag tests (#5681)

d162b5d

* Use more deterministic selector * Hover first to "slow down" e2e actions while in headless mode

Closes #5640

8e22814

- Fixed Locator to dynamically size itself to use available vertical space.

Closes #5640

d640ced

- Added new `l-overlay-dialog` size parameter. - Better approach to overlay sizing to make Properties dialogs larger vertically and fullscreen overlays more apparent to the user.

Closes #5640

1e7dfb0

- Normalized approach to numeric inputs to fix cross-browser inconsistency with input spinners. - Fixed layout problem in `Datetime.vue` component due to numeric input spinners changes.

shefalijoshi and others added 5 commits August 19, 2022 15:47

Moves condition set fix into 2.0.8 (#5673)

b0c2e66

Set Focused Image index after a imagery is selected from a timestrip …

cb1e04b

…- 5632 (#5664) * Set focused image when timestamp prop is passed in * Unused var * Create timestrip with imagery child * Add equality check for hovered image and view large image url * Cleanup

[CI] Enable couchdb e2e testing in open source (#5655)

909901b

Merge branch 'release/2.0.8', remote-tracking branch 'origin' into mi…

30f024d

…sc-ui-5640-r208

charlesh88 changed the base branch from master to release/2.0.8 August 19, 2022 21:39

charlesh88 added bug:visual Visual problem. Not a functional issue Target:2.0.8 and removed bug:visual Visual problem. Not a functional issue labels Aug 19, 2022

Closes #5640

0a8cdb3

- Added object types for Display Layout drawing objects. - Code modded in `ObjectName.vue` to grab layout object cssClass from layoutItem.type. - Big thanks to @jvigliotta for the assist with this!

charlesh88 requested review from jvigliotta, akhenry and michaelrogers August 19, 2022 22:38

cr4yfish suggested changes Aug 22, 2022

View reviewed changes

src/plugins/displayLayout/plugin.js Outdated Show resolved Hide resolved

shefalijoshi and others added 4 commits August 22, 2022 10:15

[Docs] Update CouchDB local install documentation (#5692)

affb7a5

* Update local CouchDB install docs to include docker workflow * reformat to source configuration scripts where possible * correct couchdb case Co-authored-by: John Hill <[email protected]>

Update plugin.js

6021664

charlesh88 marked this pull request as ready for review August 23, 2022 19:33

Merge branch 'release/2.0.8' into misc-ui-5640-r208

410755a

michaelrogers approved these changes Aug 23, 2022

View reviewed changes

charlesh88 enabled auto-merge (squash) August 23, 2022 20:21

akhenry disabled auto-merge August 23, 2022 22:09

akhenry requested changes Aug 23, 2022

View reviewed changes

ozyx changed the base branch from release/2.0.8 to master August 24, 2022 18:14

charlesh88 closed this Sep 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc UI fixes for release 2.0.8 #5684

Misc UI fixes for release 2.0.8 #5684

charlesh88 commented Aug 19, 2022 •

edited

Loading

codecov bot commented Aug 19, 2022 •

edited

Loading

cr4yfish left a comment

michaelrogers left a comment

akhenry left a comment

ozyx commented Aug 24, 2022

charlesh88 commented Aug 24, 2022 •

edited

Loading

Misc UI fixes for release 2.0.8 #5684

Misc UI fixes for release 2.0.8 #5684

Conversation

charlesh88 commented Aug 19, 2022 • edited Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Aug 19, 2022 • edited Loading

Codecov Report

cr4yfish left a comment

Choose a reason for hiding this comment

michaelrogers left a comment

Choose a reason for hiding this comment

akhenry left a comment

Choose a reason for hiding this comment

ozyx commented Aug 24, 2022

charlesh88 commented Aug 24, 2022 • edited Loading

charlesh88 commented Aug 19, 2022 •

edited

Loading

codecov bot commented Aug 19, 2022 •

edited

Loading

charlesh88 commented Aug 24, 2022 •

edited

Loading