Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid icons are wrong #5303

Closed
3 of 7 tasks
charlesh88 opened this issue Jun 8, 2022 · 10 comments · Fixed by #5314 or #5762
Closed
3 of 7 tasks

Grid icons are wrong #5303

charlesh88 opened this issue Jun 8, 2022 · 10 comments · Fixed by #5314 or #5762
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue needs:e2e Needs an e2e test severity:critical type:bug
Milestone
Target:2.1.1

Comments

@charlesh88
Copy link
Contributor

Summary

Grid icon artwork is wrong for many object types.
Screen Shot 2022-06-08 at 10 48 37 AM

Steps to Reproduce

  1. Create a number of different object types, particularly Display Layout, Notebook, Example Imagery, Web Page, Gauge.
  2. Note that the objects will have the correct icons in the tree view.
  3. View the folder enclosing the objects in the main view in Grid view, and note that the icon artwork is wrong.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@charlesh88 charlesh88 self-assigned this Jun 8, 2022
@unlikelyzero unlikelyzero added bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue labels Jun 8, 2022
charlesh88 added a commit that referenced this issue Jun 8, 2022
@charlesh88
Fixes #5303
8113b7c 
- Fixed scrambled SVG definitions;
- Removed some unused artwork;
@charlesh88 charlesh88 mentioned this issue Jun 8, 2022
Merged
15 tasks
@charlesh88
Copy link
Contributor Author

charlesh88 commented Jun 8, 2022 •
edited
Loading

Testing Notes

Follow Steps to Reproduce above and verify that step 3 is no longer true.

image

This codepen exercises all the SVG definition classes: https://codepen.io/charlesh88/pen/qBxJrzP

scottbell added a commit that referenced this issue Jun 9, 2022
@charlesh88 @scottbell
Fixes #5303 (#5314)
730272e 
- Fixed scrambled SVG definitions;
- Removed some unused artwork;

Co-authored-by: Scott Bell <[email protected]>
@khalidadil
Copy link
Contributor

I'm noticing that overlay plots have question marks for the icons - seems like a bug.

@akhenry akhenry reopened this Jun 10, 2022
@akhenry
Copy link
Contributor

akhenry commented Jun 10, 2022

Reopening this for merge into release/2.0.5 branch

@unlikelyzero
Copy link
Contributor

Please verify this issue "while you're in there" #3489

@shefalijoshi shefalijoshi mentioned this issue Jun 16, 2022
Merged
15 tasks
@shefalijoshi shefalijoshi self-assigned this Jun 16, 2022
@khalidadil
Copy link
Contributor

Testathon 06-23-22. Telemetry tables now seem to be missing the icon in grid view.

@shefalijoshi
Copy link
Contributor

Not fixed - there are still missing icons for telemetry tables in grid view

@unlikelyzero unlikelyzero reopened this Jun 27, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@charlesh88 charlesh88 self-assigned this Aug 1, 2022
This was referenced Aug 17, 2022
Closed
Closed
@charlesh88
Copy link
Contributor Author

Updated Testing Notes

The Telemetry Tables icon regression has been fixed for #5640 - see testing notes there.

@charlesh88 charlesh88 mentioned this issue Sep 14, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Sep 25, 2022
@charlesh88
Copy link
Contributor Author

Testathon 10-04-22 verified fixed.

@rukmini-bose
Copy link
Contributor

Testathon Verified 10/4. All grid icons seem to be correct.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 10/4

@akhenry akhenry removed the unverified label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue needs:e2e Needs an e2e test severity:critical type:bug
Projects
None yet
Milestone
Target:2.1.1
8 participants
@charlesh88 @khalidadil @akhenry @shefalijoshi @scottbell @jvigliotta @unlikelyzero @rukmini-bose