5469 search results sometimes show the wrong contextual path or no path at all master

[scottbell]

Closes #5469 #5535

Describe your changes:

Search results were using ordinal indices instead of domain object identifiers as the Vue key. Because of this, we weren't re-rendering the search results and were re-using old object paths.

I removed a lot of the old "selection" code from the ObjectPath as it was unneeded (we're not inside a tree or inspector anymore).

I also added an option to ObjectPath so we can display the target object in annotation results:

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Unit tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Changes appear not to be breaking changes?
• Appropriate unit tests included?
• Code style and in-line documentation are appropriate?
• Commit messages meet standards?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[codecov]

Codecov Report

Merging #5567 (3e160e8) into master (f493f03) will decrease coverage by 0.00%.
The diff coverage is 64.28%.

❗ Current head 3e160e8 differs from pull request most recent head a117c5f. Consider uploading reports for the commit a117c5f to get more accurate results

@@            Coverage Diff             @@
##           master    #5567      +/-   ##
==========================================
- Coverage   53.64%   53.63%   -0.01%     
==========================================
  Files         594      594              
  Lines       21780    21762      -18     
  Branches     2049     2047       -2     
==========================================
- Hits        11684    11673      -11     
+ Misses       9520     9514       -6     
+ Partials      576      575       -1     

Flag	Coverage Δ		*Carryforward flag
e2e-ci	39.54% <ø> (+0.05%)	⬆️
e2e-full	48.81% <ø> (ø)		Carriedforward from 71c43de
e2e-stable	?
unit	50.11% <64.28%> (-0.01%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
src/ui/layout/search/AnnotationSearchResult.vue	48.14% <0.00%> (-7.41%)	⬇️
src/ui/layout/search/ObjectSearchResult.vue	33.33% <ø> (-4.60%)	⬇️
src/ui/layout/search/SearchResultsDropDown.vue	55.55% <ø> (ø)
src/ui/components/ObjectPath.vue	86.66% <81.81%> (+22.15%)	⬆️
src/ui/components/ObjectView.vue	46.44% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f493f03...a117c5f. Read the comment docs.

[ozyx]

It looks good to me, and seems to work well. There is a small merge conflict caused by the recent e2e refactor, and once that's resolved should be good to go!

Sidenote: This is out-of-scope for this issue, but It would be nice if navigating to one of these objects (either the target object or one of the folders in the object path) would expand the tree path and scroll to the object. Is there an enhancement request open for this already? I took a look and the closest thing I could find was this ancient ticket: #214

[scottbell]

It looks good to me, and seems to work well. There is a small merge conflict caused by the recent e2e refactor, and once that's resolved should be good to go!

Sidenote: This is out-of-scope for this issue, but It would be nice if navigating to one of these objects (either the target object or one of the folders in the object path) would expand the tree path and scroll to the object. Is there an enhancement request open for this already? I took a look and the closest thing I could find was this ancient ticket: #214

Regarding the tree path expansion, there's this ticket:
#5439
where if you click on the "target" icon, it should expand search results. Maybe it should be turned on by default? @charlesh88 question probably.