Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results sometimes show the wrong contextual path, or no path at all #5469

Closed
7 tasks
akhenry opened this issue Jul 8, 2022 · 11 comments · Fixed by #5567 or #5599
Closed
7 tasks

Search results sometimes show the wrong contextual path, or no path at all #5469

akhenry opened this issue Jul 8, 2022 · 11 comments · Fixed by #5567 or #5599

Comments

@akhenry
Copy link
Contributor

akhenry commented Jul 8, 2022

Summary

When displaying a list of search results, the results sometimes have the wrong contextual path displayed below each result, or the path is completely absent. This may relate to #5439

Expected vs Current Behavior

Each search result should include the contextual path to the object.

Steps to Reproduce

  1. Import the attached JSON file
  2. Search for "Timer"
  3. Observe that Timer A and Timer B are shown as suggested search results, but both context paths shown are incorrect

Environment

  • Open MCT Version: 0f0a3dc
  • Deployment Type: VIPER Test, local dev

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@scottbell
Copy link
Contributor

replicated - looking into it.

@unlikelyzero
Copy link
Contributor

Steps to Reproduce
Use search to look for something that returns a number of results in a location that is clearly different from your current location.
Note that the paths displayed for results may be the path to your current view's location, not the location of the result item.

@jvigliotta
Copy link
Contributor

Verified Fixed: Testathon 8/2/22

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Aug 2, 2022

Verified Testathon 8/2/22 for objects that are a part of the tree.

Might be unrelated to this issue, but there are a whole bunch of objects that do not have any sort of path and don't appear in the tree as well. Are they being stored elsewhere?
Screen Shot 2022-08-02 at 3 22 51 PM

@akhenry
Copy link
Contributor Author

akhenry commented Aug 2, 2022

@rukmini-bose Suspect those objects were "deleted" and are unreachable from the root object. ie. they're orphaned objects.

We will look at better handling for deleted objects in Build 7, however we could just ignore any objects without an original path for now? @scottbell Thoughts?

@scottbell
Copy link
Contributor

@akhenry @rukmini-bose Yeah, that should be pretty straightforward to do!

@unlikelyzero
Copy link
Contributor

Will fix based on @rukmini-bose 's finding in #3823

@scottbell
Copy link
Contributor

@akhenry @rukmini-bose Yeah, that should be pretty straightforward to do!

I have a fix in:
#5599
to filter objects (and tags that point to objects) that don't have an originalPath

@ozyx ozyx added the unverified label Aug 4, 2022
@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 8/4/22

Created an object. Searched, it was there. Deleted it. Searched, it was no longer there.

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Aug 4, 2022
@ozyx
Copy link
Contributor

ozyx commented Aug 9, 2022

Verified Testathon 8/9/22:

Created an object. Was able to find it in the search. Tried switching focused path a few times and searching again, it still shows the correct path. Focused folders which were outside of 'My Items' folder and tested again, still shows the correct path. Deleted the object, and it no longer was able to be found via search.

@rukmini-bose
Copy link
Contributor

Verified Testathon 8/11/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment