-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable independent time conductor for stacked plot and overlay plot and bar graphs #4646
Conversation
@charlesh88 The independent time controls are not visible since they're behind the plot action buttons. Can you take a look? |
Codecov Report
@@ Coverage Diff @@
## master #4646 +/- ##
=======================================
Coverage 56.36% 56.37%
=======================================
Files 718 718
Lines 22797 22807 +10
Branches 1656 1658 +2
=======================================
+ Hits 12850 12857 +7
+ Misses 9540 9539 -1
- Partials 407 411 +4
Continue to review full report at Codecov.
|
@shefalijoshi I don't see this problem, here's what I do see, in both Chrome and Firefox: In this context, the Date picker menus have issues when the object frame is small, we're going to have to refactor those as proper menus at some point: |
… plots-independent-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
Resolves #4503
All Submissions:
Author Checklist