Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable independent time conductor for stacked plot and overlay plot and bar graphs #4646

Merged
merged 11 commits into from
Jan 7, 2022

Conversation

shefalijoshi
Copy link
Contributor

Resolves #4503

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@shefalijoshi
Copy link
Contributor Author

@charlesh88 The independent time controls are not visible since they're behind the plot action buttons. Can you take a look?

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #4646 (2e02b51) into master (22a7537) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4646   +/-   ##
=======================================
  Coverage   56.36%   56.37%           
=======================================
  Files         718      718           
  Lines       22797    22807   +10     
  Branches     1656     1658    +2     
=======================================
+ Hits        12850    12857    +7     
+ Misses       9540     9539    -1     
- Partials      407      411    +4     
Impacted Files Coverage Δ
src/plugins/charts/BarGraphView.vue 68.29% <100.00%> (+1.91%) ⬆️
src/ui/components/ObjectView.vue 44.02% <100.00%> (+0.92%) ⬆️
src/plugins/imagery/components/ImageryView.vue 36.76% <0.00%> (-2.81%) ⬇️
src/plugins/imagery/components/ImageryTimeView.vue 72.57% <0.00%> (+0.57%) ⬆️
src/api/time/IndependentTimeContext.js 80.26% <0.00%> (+1.31%) ⬆️
src/api/composition/DefaultCompositionProvider.js 81.81% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a7537...2e02b51. Read the comment docs.

@charlesh88
Copy link
Contributor

charlesh88 commented Jan 5, 2022

@charlesh88 The independent time controls are not visible since they're behind the plot action buttons. Can you take a look?

@shefalijoshi I don't see this problem, here's what I do see, in both Chrome and Firefox:

Main view
image

In a Display Layout
image

In this context, the Date picker menus have issues when the object frame is small, we're going to have to refactor those as proper menus at some point:

image

shefalijoshi and others added 4 commits January 5, 2022 14:27
- Added `flex: 0 0 auto` to toggle switch when in ITC to prevent
element from being crunched when window or frame is very small;
charlesh88
charlesh88 previously approved these changes Jan 5, 2022
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shefalijoshi shefalijoshi changed the title Enable independent time conductor for stacked plot and overlay plot. Enable independent time conductor for stacked plot and overlay plot and bar graphs Jan 6, 2022
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@shefalijoshi shefalijoshi merged commit f6934a4 into master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add independent time conductor to plots
2 participants