Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .spec.js file not being executed. #4606

Closed
trusktr opened this issue Dec 17, 2021 · 5 comments
Closed

fix .spec.js file not being executed. #4606

trusktr opened this issue Dec 17, 2021 · 5 comments
Assignees
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@trusktr
Copy link
Contributor

trusktr commented Dec 17, 2021

There's a single .spec.js file within the src/ folder not being executed. It needs to be renamed to FooSpec.js format to be picked up and executed. It will need import paths fixed, and imports will be undefined due to trying to import defaults from ES modules.

src/plugins/exportAsJSONAction/ExportAsJSONAction.spec.js

cc @shefalijoshi

@trusktr trusktr added the type:maintenance tests, chores, or project maintenance label Dec 17, 2021
@mariuszr
Copy link
Contributor

Hi @trusktr, I believe it has been considered in the merged PR #4225 that considered changes in the ExportAsJSONAction.js plugin and provided the reimplemented ExportAsJSONActionSpec.js unit test. Please check it.

Hi @davetsay, could you please confirm my above supposition?

@unlikelyzero
Copy link
Contributor

Closed by PR #4225

@unlikelyzero
Copy link
Contributor

Assigning to @trusktr to add testing notes

@trusktr
Copy link
Contributor Author

trusktr commented Jan 4, 2022

In the pull request we can see code coverage increased for ExportAsJSONAction.js due to now-actually-executed test file.

Additionally we can verify in the test output all 9 it tests in the test file executed and passed:

  Export as JSON plugin
    ✓ Export as JSON action exist (4ms)
    ✓ ExportAsJSONAction applies to folder (4ms)
    ✓ ExportAsJSONAction applies to telemetry.plot.overlay (4ms)
    ✓ ExportAsJSONAction applies to telemetry.plot.stacked (5ms)
    ✓ ExportAsJSONAction applies does not applies to non-creatable objects (7ms)
    ✓ ExportAsJSONAction exports object from tree (7ms)
    ✓ ExportAsJSONAction skips non-creatable objects from tree (4ms)
    ✓ can export self-containing objects (5ms)
    ✓ exports links to external objects as new objects (5ms)

charlesh88 added a commit that referenced this issue Jan 5, 2022
- Added `flex: 0 0 auto` to toggle switch when in ITC to prevent
element from being crunched when window or frame is very small;
@unlikelyzero unlikelyzero added Target:1.8.4 and removed needs:test instructions Missing testing notes labels Jan 7, 2022
@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 7, 2022
shefalijoshi added a commit that referenced this issue Jan 7, 2022
…nd bar graphs (#4646)

* Enable independent time conductor for stacked plot and overlay plot.

* Lint fixes

* Fixes for #4503 and #4606
- Added `flex: 0 0 auto` to toggle switch when in ITC to prevent
element from being crunched when window or frame is very small;

* Add independent time conductor to bar graphs

* Add timeContext to bar graphs

Co-authored-by: Charles Hacskaylo <[email protected]>
@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 1/26/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

4 participants