-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix .spec.js file not being executed. #4606
Comments
Hi @trusktr, I believe it has been considered in the merged PR #4225 that considered changes in the ExportAsJSONAction.js plugin and provided the reimplemented ExportAsJSONActionSpec.js unit test. Please check it. Hi @davetsay, could you please confirm my above supposition? |
Closed by PR #4225 |
Assigning to @trusktr to add testing notes |
In the pull request we can see code coverage increased for Additionally we can verify in the test output all 9
|
…nd bar graphs (#4646) * Enable independent time conductor for stacked plot and overlay plot. * Lint fixes * Fixes for #4503 and #4606 - Added `flex: 0 0 auto` to toggle switch when in ITC to prevent element from being crunched when window or frame is very small; * Add independent time conductor to bar graphs * Add timeContext to bar graphs Co-authored-by: Charles Hacskaylo <[email protected]>
Verified Fixed - Testathon 1/26/2022 |
There's a single
.spec.js
file within thesrc/
folder not being executed. It needs to be renamed toFooSpec.js
format to be picked up and executed. It will need import paths fixed, and imports will be undefined due to trying to import defaults from ES modules.src/plugins/exportAsJSONAction/ExportAsJSONAction.spec.js
cc @shefalijoshi
The text was updated successfully, but these errors were encountered: