-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snapshots] Blank PNG/JPG image generated for snapshots #4612
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4612 +/- ##
==========================================
- Coverage 57.27% 57.22% -0.05%
==========================================
Files 718 718
Lines 22771 22771
Branches 1653 1653
==========================================
- Hits 13041 13031 -10
- Misses 9314 9323 +9
- Partials 416 417 +1
Continue to review full report at Codecov.
|
@nikhilmandlik can we add a test for this considering this has regressed at least once? |
I think I can add e2e tests for notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer Checklist
- Changes appear to address issue?
- Changes appear not to be breaking changes?
- Appropriate unit tests included?
- Code style and in-line documentation are appropriate?
- Commit messages meet standards?
- Has associated issue been labelled
unverified
? (only applicable if this PR closes the issue) - Has associated issue been labelled
bug
? (only applicable if this PR is for a bug fix) - List of Acceptance Tests Performed.
Resolves:
resolves: #4526
All Submissions:
Author Checklist