Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshots] Blank PNG/JPG image generated for snapshots #4612

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

nikhilmandlik
Copy link
Contributor

@nikhilmandlik nikhilmandlik commented Dec 17, 2021

Resolves:

resolves: #4526

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@nikhilmandlik nikhilmandlik requested review from akhenry and shefalijoshi and removed request for akhenry December 17, 2021 21:07
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #4612 (9f3913c) into master (722e2e2) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4612      +/-   ##
==========================================
- Coverage   57.27%   57.22%   -0.05%     
==========================================
  Files         718      718              
  Lines       22771    22771              
  Branches     1653     1653              
==========================================
- Hits        13041    13031      -10     
- Misses       9314     9323       +9     
- Partials      416      417       +1     
Impacted Files Coverage Δ
src/plugins/notebook/components/NotebookEmbed.vue 0.00% <ø> (ø)
src/tools/url.js 69.23% <0.00%> (-30.77%) ⬇️
src/api/composition/DefaultCompositionProvider.js 76.19% <0.00%> (-4.77%) ⬇️
src/ui/inspector/details/Properties.vue 63.63% <0.00%> (-1.82%) ⬇️
src/ui/router/Browse.js 86.48% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722e2e2...9f3913c. Read the comment docs.

@unlikelyzero
Copy link
Contributor

@nikhilmandlik can we add a test for this considering this has regressed at least once?

@nikhilmandlik
Copy link
Contributor Author

@nikhilmandlik can we add a test for this considering this has regressed at least once?

I think I can add e2e tests for notebook

Copy link
Contributor

@michaelrogers michaelrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)
  • List of Acceptance Tests Performed.

@shefalijoshi shefalijoshi merged commit 4775c88 into master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Snapshots] Blank PNG/JPG image generated for snapshots
4 participants