Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapshots] Blank PNG/JPG image generated for snapshots #4526

Closed
3 of 5 tasks
unlikelyzero opened this issue Dec 2, 2021 · 5 comments · Fixed by #4612
Closed
3 of 5 tasks

[Snapshots] Blank PNG/JPG image generated for snapshots #4526

unlikelyzero opened this issue Dec 2, 2021 · 5 comments · Fixed by #4612
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Milestone
Target: 1.8.3

Comments

@unlikelyzero
Copy link
Contributor

Summary

We are no longer able to download a PNG/JPG of a snapshot

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Create a Snapshot of an object
  2. Open Preview of Object
  3. Click on PNG/JPG Button
  4. Open PNG/JPG

Environment

  • Open MCT Version: 1.8.1
  • Deployment Type: npm
  • OS: N/A
  • Browser: Chrome 97

Additional Information
@unlikelyzero unlikelyzero added type:bug severity:blocker bug:regression It used to work. Now it doesn't :( labels Dec 2, 2021
@unlikelyzero
Copy link
Contributor Author

Bumping severity to blocker since this is part of GDS Testing.

nikhilmandlik added a commit that referenced this issue Dec 17, 2021
@nikhilmandlik
[Snapshots] Blank PNG/JPG image generated for snapshots #4526
b8ab98d
@nikhilmandlik nikhilmandlik mentioned this issue Dec 17, 2021
Merged
8 tasks
shefalijoshi pushed a commit that referenced this issue Dec 29, 2021
@nikhilmandlik
[Snapshots] Blank PNG/JPG image generated for snapshots #4526 (#4612)
4775c88
@unlikelyzero
Copy link
Contributor Author

Testing Notes

  1. Create a Snapshot of an object
  2. Open Preview of Object
  3. Click on PNG/JPG Button
  4. Open PNG/JPG

@unlikelyzero unlikelyzero added this to the Target: 1.8.3 milestone Jan 6, 2022
@shefalijoshi
Copy link
Contributor

Verified saving a snapshot to the notebook snapshots bin, clicking the snapshot preview image and then downloading via the PNG and JPG buttons works.
Unable to verify this for the default notebook.

@unlikelyzero
Copy link
Contributor Author

Verified Fixed

@unlikelyzero unlikelyzero removed their assignment Jan 6, 2022
@shefalijoshi shefalijoshi mentioned this issue Jan 6, 2022
Closed
5 tasks
@shefalijoshi
Copy link
Contributor

Verified fixed on default notebook as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Projects
None yet
Milestone
Target: 1.8.3
Development

Successfully merging a pull request may close this issue.

[Snapshots] Blank PNG/JPG image generated for snapshots nasa/openmct
3 participants
@nikhilmandlik @shefalijoshi @unlikelyzero