Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bar graph composition policy fix to allow condition set creation. #4598

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Bar graph composition policy fix to allow condition set creation. #4598

merged 1 commit into from
Dec 16, 2021

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Dec 16, 2021 •
edited
Loading

Resolves #4542

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

nikhilmandlik
nikhilmandlik approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@nikhilmandlik nikhilmandlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Dec 16, 2021 •
edited
Loading

Reviewer Checklist

  • Changes appear to address issue?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)

@nikhilmandlik nikhilmandlik enabled auto-merge (squash) December 16, 2021 19:14
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release/1.8.2@a2ac22d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/1.8.2    #4598   +/-   ##
================================================
  Coverage                 ?   57.16%           
================================================
  Files                    ?      726           
  Lines                    ?    22911           
  Branches                 ?     1651           
================================================
  Hits                     ?    13098           
  Misses                   ?     9400           
  Partials                 ?      413

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ac22d...85c08ea. Read the comment docs.

@nikhilmandlik nikhilmandlik merged commit bf86972 into release/1.8.2 Dec 16, 2021
@nikhilmandlik nikhilmandlik linked an issue Dec 16, 2021 that may be closed by this pull request
Unable to create new Condition set #4542
Closed
5 tasks
@nikhilmandlik nikhilmandlik deleted the fix-create-conditionSet branch December 16, 2021 19:15
unlikelyzero pushed a commit that referenced this pull request Dec 17, 2021
@shefalijoshi @nikhilmandlik
1.8.2 merge into master - the version of open mct after the last but …
70f2fad 
…equally as important (#4611)

* Release 1.8.2

* Trasactions tests are ids equal fix 1.8.2 (#4593)

* test fix

* return promise on 'onSave'

* "Export as JSON" yielding corrupted data #4577 (#4585)

#4577

* Fix date picker default time setting (#4581)

Fix mode dropdown position
Fix unlistening of upstream events

* Bar graph composition policy fix to allow condition set creation. (#4598)

* Use image timestamp instead of image index to show large view (#4591)

* Use image timestamp instead of image index to show large view

* Fix failing test

Co-authored-by: Nikhil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilmandlik nikhilmandlik nikhilmandlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create new Condition set
2 participants
@shefalijoshi @nikhilmandlik