Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Export as JSON" yielding corrupted data #4585

Merged
merged 1 commit into from
Dec 16, 2021
Merged

"Export as JSON" yielding corrupted data #4585

merged 1 commit into from
Dec 16, 2021

Conversation

nikhilmandlik
Copy link
Contributor

@nikhilmandlik nikhilmandlik commented Dec 15, 2021 •
edited
Loading

fixes: #4577

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

@nikhilmandlik nikhilmandlik changed the title "Export as JSON" yielding corrupted data #4577 "Export as JSON" yielding corrupted data Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/1.8.2@212448c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 12e42eb differs from pull request most recent head b0378ab. Consider uploading reports for the commit b0378ab to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##             release/1.8.2    #4585   +/-   ##
================================================
  Coverage                 ?   56.97%           
================================================
  Files                    ?      722           
  Lines                    ?    22770           
  Branches                 ?     1651           
================================================
  Hits                     ?    12974           
  Misses                   ?     9383           
  Partials                 ?      413

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212448c...b0378ab. Read the comment docs.

akhenry
akhenry previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y
  5. Has associated issue been labelled unverified? (only applicable if this PR closes the issue) Y

@nikhilmandlik nikhilmandlik changed the base branch from master to release/1.8.2 December 16, 2021 00:18
@nikhilmandlik nikhilmandlik dismissed akhenry’s stale review December 16, 2021 00:18

The base branch was changed.

@nikhilmandlik nikhilmandlik enabled auto-merge (squash) December 16, 2021 03:23
jvigliotta
jvigliotta approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice simple change :)

@jvigliotta jvigliotta merged commit 4458360 into release/1.8.2 Dec 16, 2021
@jvigliotta jvigliotta deleted the export-tree-cleanup branch December 16, 2021 03:38
unlikelyzero pushed a commit that referenced this pull request Dec 17, 2021
@shefalijoshi @nikhilmandlik
1.8.2 merge into master - the version of open mct after the last but …
70f2fad 
…equally as important (#4611)

* Release 1.8.2

* Trasactions tests are ids equal fix 1.8.2 (#4593)

* test fix

* return promise on 'onSave'

* "Export as JSON" yielding corrupted data #4577 (#4585)

#4577

* Fix date picker default time setting (#4581)

Fix mode dropdown position
Fix unlistening of upstream events

* Bar graph composition policy fix to allow condition set creation. (#4598)

* Use image timestamp instead of image index to show large view (#4591)

* Use image timestamp instead of image index to show large view

* Fix failing test

Co-authored-by: Nikhil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvigliotta jvigliotta jvigliotta approved these changes

@davetsay davetsay Awaiting requested review from davetsay

@akhenry akhenry Awaiting requested review from akhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Export as JSON" yielding corrupted data
4 participants
@nikhilmandlik @akhenry @jvigliotta @unlikelyzero