[Display Layout] Right click on item acts as sticky move #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidadil
changed the title
jvigliotta
reviewed
Aug 23, 2021
| @@ -33,7 +33,7 @@ | |||
| <slot></slot> | |||
| <div | |||
| class="c-frame__move-bar" | |||
| @mousedown="isEditing ? startMove([1,1], [0,0], $event) : null" | |||
| @mousedown.left="isEditing ? startMove([1,1], [0,0], $event) : null" | |||
There was a problem hiding this comment.
Know this wasn't you, but can you separate out the logic from the template.
jvigliotta
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Reviewer Checklist
| Check | Passed |
|---|---|
| Changes appear to address issue?? | Y |
| Appropriate unit tests included? | existing |
| Code style and in-line documentation are appropriate? | Y |
| Commit messages meet standards? | Y |
| Has associated issue been labelled unverified? (if PR closes issue) | Y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3343
Author Checklist
Testing instructions are included in #3343