-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to [Display Layout] Right click on item acts as sticky move #3343 #3717
Conversation
@Quintis1212 Thanks for pushing a PR for this! We really appreciate your contribution. I wonder if we might be able to fix this in an even simpler way. What if we just added a Just a point of housekeeping: we will need a Contributor License Agreement signed by you before we can merge your code - https://nasa.github.io/openmct/static/files/ind-cla-open-mct.pdf Once signed, please send it to [email protected] Thank you! |
Hello !) thank you for response ) @Move="move" directive is listening left and right mouse keys, and left modifier also not help: ` |
@Quintis1212 Just wanted to follow up to see if you had a chance to fill out the Contributor License Agreement and send that in to: [email protected] ? |
@Quintis1212 I tried the code change I suggested in #3717 (comment) and it appears to work for me. Did you have problems when you tried this? Maybe you found a bug that I didn't? |
@Quintis1212 Hi, we're hoping to close out this PR. Did you have any thoughts on my previous comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments in #3717 (comment) need to be addressed.
Hi @Quintis1212 thank you so much for the contribution, we're going to take this one over in the PR #4126, as we're looking to get this in pretty soon. |
Hello everyone ) This is fix for bug - #3343 .
As I found out @click.capture and v-on:click not listening for right mouse key down , so I applyed @mousedown.right and @mouseup.right attributes. This attributes call function that change variable this.mouseRightKeyCatch to true or false .This variable is used in move function , and mouseRightKeyCatch variable stops it when right key mouse button clicked.