Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to [Display Layout] Right click on item acts as sticky move #3343 #3717

Closed
wants to merge 4 commits into from

Conversation

Quintis1212
Copy link

Hello everyone ) This is fix for bug - #3343 .
As I found out @click.capture and v-on:click not listening for right mouse key down , so I applyed @mousedown.right and @mouseup.right attributes. This attributes call function that change variable this.mouseRightKeyCatch to true or false .This variable is used in move function , and mouseRightKeyCatch variable stops it when right key mouse button clicked.

@akhenry
Copy link
Contributor

akhenry commented Mar 1, 2021

@Quintis1212 Thanks for pushing a PR for this! We really appreciate your contribution.

I wonder if we might be able to fix this in an even simpler way. What if we just added a .left modifier to the mousedown event handler that initiates the move? That way we just filter out all right clicks, so a right click will never trigger the move behavior?

Just a point of housekeeping: we will need a Contributor License Agreement signed by you before we can merge your code - https://nasa.github.io/openmct/static/files/ind-cla-open-mct.pdf Once signed, please send it to [email protected]

Thank you!

@akhenry akhenry self-requested a review March 1, 2021 17:47
@Quintis1212
Copy link
Author

Hello !) thank you for response ) @Move="move" directive is listening left and right mouse keys, and left modifier also not help:
`
@dragover.left="handleDragOver"
@click.left="bypassSelection"
@drop.left="handleDrop"

`
It means that we must listen right click of mouse to prevent this bug )

@jvigliotta
Copy link
Contributor

@Quintis1212 Just wanted to follow up to see if you had a chance to fill out the Contributor License Agreement and send that in to: [email protected] ?

@akhenry
Copy link
Contributor

akhenry commented May 6, 2021

@Quintis1212 I tried the code change I suggested in #3717 (comment) and it appears to work for me. Did you have problems when you tried this? Maybe you found a bug that I didn't?

@akhenry
Copy link
Contributor

akhenry commented Aug 9, 2021

@Quintis1212 Hi, we're hoping to close out this PR. Did you have any thoughts on my previous comment?

@jvigliotta jvigliotta added the source:community Community contribution or request label Aug 9, 2021
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in #3717 (comment) need to be addressed.

@jvigliotta
Copy link
Contributor

Hi @Quintis1212 thank you so much for the contribution, we're going to take this one over in the PR #4126, as we're looking to get this in pretty soon.

@jvigliotta jvigliotta closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants