Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notebook] Press Enter to save notebook entries #3580

Merged
merged 8 commits into from
Feb 18, 2021
Merged

[Notebook] Press Enter to save notebook entries #3580

merged 8 commits into from
Feb 18, 2021

Conversation

nikhilmandlik
Copy link
Contributor

@nikhilmandlik nikhilmandlik commented Dec 4, 2020 •
edited
Loading

Resolves:

resolves: #3579

Notes:

  1. Enter to save entry
  2. SHIFT + Enter to add line break inside entry

Author Checklist:

Check Passed
Changes address original issue? Y
Unit tests included and/or updated with changes? N/A
Command line build passes? Y
Changes have been smoke-tested? Y
Testing instructions included? Y

Screenshots:

Screen Shot 2020-12-04 at 11 00 22 AM

@nikhilmandlik nikhilmandlik force-pushed the save-notebook-entry-on-enter branch 3 times, most recently from 19e4eb1 to 4c3d63b Compare December 9, 2020 21:54
davetsay
davetsay requested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more questioning rather than requesting changes.

@davetsay davetsay self-requested a review December 11, 2020 21:02
@nikhilmandlik nikhilmandlik force-pushed the save-notebook-entry-on-enter branch from 4c3d63b to 05f48b8 Compare December 11, 2020 22:48
deeptailor
deeptailor suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@deeptailor deeptailor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great, but I have a few suggestions.

@nikhilmandlik nikhilmandlik force-pushed the save-notebook-entry-on-enter branch from 05f48b8 to b9955a9 Compare December 16, 2020 01:40
deeptailor
deeptailor suggested changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@deeptailor deeptailor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change needed to make it easier to read

@nikhilmandlik nikhilmandlik force-pushed the save-notebook-entry-on-enter branch from a5130c8 to 95e27a8 Compare January 5, 2021 19:06
deeptailor
deeptailor suggested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@deeptailor deeptailor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one comment

@akhenry
Copy link
Contributor

akhenry commented Feb 17, 2021

@nikhilmandlik Let's get this bad boy merged

deeptailor
deeptailor approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@deeptailor deeptailor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeptailor
Copy link
Contributor

Reviewer Checklist

Changes appear to address issue? Yes
Appropriate unit tests included? N/A
Code style and in-line documentation are appropriate? Yes
Commit messages meet standards? Yes
Has associated issue been labelled unverified? (only applicable if this PR closes the issue) Yes

davetsay
davetsay approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay merged commit 7623a06 into master Feb 18, 2021
@davetsay davetsay deleted the save-notebook-entry-on-enter branch February 18, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetsay davetsay davetsay approved these changes

@deeptailor deeptailor deeptailor approved these changes

@charlesh88 charlesh88 Awaiting requested review from charlesh88

@akhenry akhenry Awaiting requested review from akhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Notebook] Press Enter to save notebook entries
4 participants
@nikhilmandlik @akhenry @deeptailor @davetsay