Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notebook] Press Enter to save notebook entries #3579

Closed
nikhilmandlik opened this issue Dec 4, 2020 · 0 comments · Fixed by #3580
Closed

[Notebook] Press Enter to save notebook entries #3579

nikhilmandlik opened this issue Dec 4, 2020 · 0 comments · Fixed by #3580
Assignees
@nikhilmandlik
Labels
type:enhancement

Comments

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Dec 4, 2020 •
edited
Loading

Description:

https://docs.google.com/spreadsheets/d/1UF5OyLWYE9x7q56jf6j31JmicKpF-nYC5-OYeOLaghw/edit#gid=0

Let's discuss this first. Is this definitely the default behavior we want? Real world usage may involve longer entries, and there may be restrictions on editing entries at some point.

CH - Enter to save, ctrl-enter for new line
NM - Enter to save, shift+enter for new line :P

Testing instructions:

  1. Create new Notebook or use existing one.
  2. click on add new entry
  3. Add some text then press enter (should remove focus from this entry)
  4. Add some text then press SHIFT+enter, this should take to new line (should keep focus from this entry)
  5. Add some text then press enter (should remove focus from this entry)
  6. navigate away from this Notebook
  7. Go back to same notebook and make sure all entries have correct texts inside.

Screenshots:

Screen Shot 2020-12-04 at 11 00 22 AM
@nikhilmandlik nikhilmandlik self-assigned this Dec 4, 2020
nikhilmandlik added a commit that referenced this issue Dec 4, 2020
@nikhilmandlik
[Notebook] Press Enter to save notebook entries #3579
adfe288
@nikhilmandlik nikhilmandlik mentioned this issue Dec 4, 2020
Merged
nikhilmandlik added a commit that referenced this issue Dec 4, 2020
@nikhilmandlik
[Notebook] Press Enter to save notebook entries #3579
9ec071a
nikhilmandlik added a commit that referenced this issue Dec 7, 2020
@nikhilmandlik
[Notebook] Press Enter to save notebook entries #3579
19e4eb1
nikhilmandlik added a commit that referenced this issue Dec 9, 2020
@nikhilmandlik
[Notebook] Press Enter to save notebook entries #3579
4c3d63b
nikhilmandlik added a commit that referenced this issue Dec 11, 2020
@nikhilmandlik
[Notebook] Press Enter to save notebook entries #3579
05f48b8
nikhilmandlik added a commit that referenced this issue Dec 16, 2020
@nikhilmandlik
[Notebook] Press Enter to save notebook entries #3579
2a8ce5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhilmandlik nikhilmandlik

Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Notebook] Press Enter to save notebook entries nasa/openmct
1 participant
@nikhilmandlik