Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notebook] Create Snapshot directly from any frame in a layout #3300

Closed
charlesh88 opened this issue Aug 13, 2020 · 4 comments · Fixed by #4099
Closed

[Notebook] Create Snapshot directly from any frame in a layout #3300

charlesh88 opened this issue Aug 13, 2020 · 4 comments · Fixed by #4099

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 13, 2020

Create snapshot directly from any element's frame in a Display or Flexible Layout.

Design

A new button added to a Layout element's frame that exposes the Snapshot menu.
Screen Shot 2020-08-13 at 2 49 19 PM

In the short-term, add the Snapshot button before the current View Large button. In the longer-term, this functionality ties in with the 3 Dots menu design #3298. Right now though, this issue and its UI provides a little more detail on how this button element should work in the short-term. See the UI here: https://drive.google.com/file/d/1QIuOKze72K_SyM1QrH7lMrm_D-1gbNO1/view?usp=sharing

@charlesh88 charlesh88 changed the title [Notebook] Create Snapshot directly from any element in a layout [Notebook] Create Snapshot directly from any frame in a layout Aug 13, 2020
@unlikelyzero
Copy link
Contributor

will retest after #4144

@charlesh88
Copy link
Contributor Author

Testing Notes

  1. Go to a Display Layout, add items to it and save it.
  2. Click the camera icon in any object's frame:

image

  1. Choose Save to Notebook Snapshots.
  2. Verify that a new Snapshot was created in the Snapshots holder area.
  3. Click the thumbnail of the new Snapshot, and verify that the Snapshot image is from that layout frame element:

image

@charlesh88
Copy link
Contributor Author

Testathon 8-26-21: verified fixed.

@kobe1104
Copy link
Contributor

Verified fixed - testathon 8/26/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants