Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance view controls and actions with a "3 Dot" button and menu #3298

Closed
charlesh88 opened this issue Aug 13, 2020 · 8 comments
Closed

Enhance view controls and actions with a "3 Dot" button and menu #3298

charlesh88 opened this issue Aug 13, 2020 · 8 comments

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 13, 2020

As we continue to add new capabilities and gestures to existing views (some of which are becoming overloaded with controls; Telemetry Table, I'm looking at you) we need a better overall strategy to organize and utilize space for controls and gestures within a given view and context.

Solution: the 3 Dot button and menu.

Goals of the approach:

  • Consolidate all options for a given object and context into a “3 dots” button and resulting menu.
  • Make it easier to add and manage gestures, capabilities and functions for views and contexts.

UI for this task is here: https://drive.google.com/file/d/1QIuOKze72K_SyM1QrH7lMrm_D-1gbNO1/view?usp=sharing
Spreadsheet of views, contexts and actions is here: https://docs.google.com/spreadsheets/d/1vwsQLwCtA31ueTOX6EXdCqm9bksgi6O6eTwkGYJAgqY/edit#gid=1216360461

@akhenry
Copy link
Contributor

akhenry commented Aug 18, 2020

See this comment for notes on how to share view context with actions.

@deeptailor
Copy link
Contributor

Testing Notes:

  1. Verify context menu actions work as expected.
  2. Create a telemetry table, add some telemetry to it.
  3. Verify the pause, expand columns buttons etc work as expected.
  4. Click on the three dot button, and verify the state of the buttons mentioned above are in sync.
  5. Verify overall usability of three dot menu button, and context menu actions.
  6. Create a display layout, add an alpha numeric telemetry to it.
  7. Context click and use new add to notebook and copy to clipboard context menu actions.
  8. Verify the above works as expected.

@deeptailor
Copy link
Contributor

@charlesh88 - Any other testing notes to add?

@akhenry akhenry closed this as completed Nov 19, 2020
@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 11/20/20

@shefalijoshi
Copy link
Contributor

Tried the Move action on a new Notebook domain object to a different folder.

It appears to duplicate the notebook rather than move it as I can see it in the original location as well as the new one.
image

image

@davetsay
Copy link
Contributor

verified most common 3 dot actions

@charlesh88
Copy link
Contributor Author

Looked at items in #3532 and did additional poking. Verified fixed Testathon 11-30-20.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 11/30/2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants