ci: trigger slow downstream libraries tests suites before release #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Francesco Bruzzesi <[email protected]>
FBruzzesi
approved these changes
Nov 6, 2024
MarcoGorelli
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
thanks @EdAbati and @FBruzzesi !
cool, let's see if this works - if we manage to get into Plotly then we should include that too, so it's good that we're setting this up already
MarcoGorelli
pushed a commit
to MarcoGorelli/narwhals
that referenced
this pull request
Nov 7, 2024
…rwhals-dev#1321) Co-authored-by: Francesco Bruzzesi <[email protected]> --------- Co-authored-by: Francesco Bruzzesi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
EDIT: I changed my mind 😄 I think the "slow tests" and the "publish" workflows should all run in the bump-version PR. So we can see if everything went well before merging.
The flow would be:
The slow tests are triggered when a tag is pushed to a branch that is notmain. Since "Bump version" creates a tag on abump-versionbranch, this should also trigger the slow tests when the bump version PR is made.I also changed the "Publish Python" workflow to be triggered on tag pushes on
main.The flow would be:1. bump version2. PR with new tag3. slow tests running along side all tests4. merge PR to main5. Publish workflow is triggered6. Library published and celebrationsCurrently the "publish" workflow is triggered in the "bump version" PR though. And you can see the results of the workflow before merging tomain. Is this something that we need to keep?