-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add vegafusion in ci checks #1228
Conversation
thanks @EdAbati - this is awesome, but " Successful in 27m " is probably too much for every commit 😄 perhaps we can only trigger this one if we apply some label, so then we can just trigger this before releases? |
Ok CI is green, but it takes quite a lot. Using caching, the build time decreases but Do you know any tricks to speed this up a bit? Otherwise I would suggest to treat all these downstream libraries tests as "integration tests" and not run them at every push. For example, we could run them just before merging a PR. Is it by using Thoughts? @MarcoGorelli @FBruzzesi EDIT: Marco typed faster than me :D |
Happy to do that. I don't have strong opinions on what should trigger this or when to test these. Should we run these test before release and triggered by new tag? |
on: | ||
workflow_call: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is what I meant, but now this can be triggered:
- by other workflows (i.e. in the 1st step of the publish workflow here )
- manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's give this a go - thanks @EdAbati !
@EdAbati is it possible to have most downstream tests run on every commit, but only the slow ones (for now, just vegafusion) only run before releases? |
I will have a look today 👀 |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.