Fix bug where Module.build
didn't follow through structs containing ports properly, plus improved debug messaging.
#541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR has 2 main components:
PortRulesViolationException
) when aLogicStructure
contains a port of aModule
.PortRulesViolationException
s which shows the full stack of signals that led to the exception, which should make it much easier to debug these types of issues.Thank you to @desmonddak for finding this issue during development of intel/rohd-hcl#152
An example of the new format for a tracing error (in this case, a missing
addInput
):There's also some doc updates and improvements in
toString
s and messages.Related Issue(s)
N/A
Testing
Added tests to cover the scenarios
Backwards-compatibility
No, though messages from the exception have changed
Documentation
No