PT-6909 Apply matcher aliases to tables on config load #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarvardt
force-pushed
the
patch/apply-matcher-aliases
branch
from
4cf7c1b to
0557f30
Compare
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 36.53% 43.18% +6.64%
==========================================
Files 8 8
Lines 260 308 +48
==========================================
+ Hits 95 133 +38
- Misses 159 168 +9
- Partials 6 7 +1
Continue to review full report at Codecov.
|
vgarvardt
force-pushed
the
patch/apply-matcher-aliases
branch
from
0557f30 to
1030300
Compare
vgarvardt
force-pushed
the
patch/apply-matcher-aliases
branch
from
1030300 to
9398461
Compare
vgarvardt
force-pushed
the
patch/apply-matcher-aliases
branch
from
8860bba to
b4b46b2
Compare
vgarvardt
force-pushed
the
patch/apply-matcher-aliases
branch
from
b4b46b2 to
bc7f4d1
Compare
|
👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last piece extracted from #110
Instead of passing matcher aliases everywhere and checking them - they are checked and replaced on config load once.
Dependend on #112 and has to be rebased after merge.