PT-6909 Extracted reader options to builder from private methods #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 35.19% 36.53% +1.34%
==========================================
Files 6 8 +2
Lines 233 260 +27
==========================================
+ Hits 82 95 +13
- Misses 145 159 +14
Partials 6 6
Continue to review full report at Codecov.
|
Comment on lines
+36
to
+46
| assert.Equal(t, tableCfg.Filter.Match, tableOpt.Match) | ||
| assert.Equal(t, tableCfg.Filter.Limit, tableOpt.Limit) | ||
| assert.Equal(t, tableCfg.Filter.Sorts, tableOpt.Sorts) | ||
|
|
||
| require.Equal(t, len(tableCfg.Relationships), len(tableOpt.Relationships)) | ||
| for i := range tableCfg.Relationships { | ||
| assert.Equal(t, tableCfg.Relationships[i].Table, tableOpt.Relationships[i].Table) | ||
| assert.Equal(t, tableCfg.Relationships[i].ForeignKey, tableOpt.Relationships[i].ForeignKey) | ||
| assert.Equal(t, tableCfg.Relationships[i].ReferencedTable, tableOpt.Relationships[i].ReferencedTable) | ||
| assert.Equal(t, tableCfg.Relationships[i].ReferencedKey, tableOpt.Relationships[i].ReferencedKey) | ||
| } |
There was a problem hiding this comment.
Why not use assert.EqualValues?
There was a problem hiding this comment.
tableCfg.Relationships and tableOpt.Relationships have different types, but fields list is the same
|
|
||
| assert.Equal(t, tableCfg.Filter.Match, tableOpt.Match) | ||
| assert.Equal(t, tableCfg.Filter.Limit, tableOpt.Limit) | ||
| assert.Equal(t, tableCfg.Filter.Sorts, tableOpt.Sorts) |
There was a problem hiding this comment.
should be here require as well?
There was a problem hiding this comment.
not need to stop test if this condition is failing, we can check other asserts as well even if this one is bad
|
👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more piece extracted from #110
This time - reader options extracted from implementations private methods to a builder function.