fix: autocompletion for argument values, more trigger characters

[acao]

fixes #2068 🎉 and #1894 (i think - @rchl do you agree?)

simplifies the code a bit. untangles a mess that I left when introducing argument value completion last year.

introduces more triggerCharacters to monaco-graphql as a precursor to #1997

fixes this bug across the entire ecosystem by fixing the issue at the core graphql-language-service-server level

[github-actions]

The latest changes of this PR are available as canary in npm (based on the declared changesets):

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

[codecov]

Codecov Report

Merging #2070 (bb52471) into main (2d91916) will decrease coverage by 2.20%.
The diff coverage is 67.10%.

@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
- Coverage   65.70%   63.50%   -2.21%     
==========================================
  Files          85       94       +9     
  Lines        5106     5466     +360     
  Branches     1631     1714      +83     
==========================================
+ Hits         3355     3471     +116     
- Misses       1747     1990     +243     
- Partials        4        5       +1     

Impacted Files	Coverage Δ
packages/codemirror-graphql/src/hint.ts	94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts	100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts	47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts	100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts	0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts	89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts	79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx	63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts	100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts	5.33% <ø> (ø)
... and 41 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503c376...bb52471. Read the comment docs.

[github-actions]

🚀 Deployed on https://61a62137846ba300880858b8--graphiql-test.netlify.app

[github-actions]

🚀 Deployed on https://61a6211974be6a008c494fde--graphiql-webpack-example.netlify.app

[github-actions]

🚀 Deployed on https://61a621696bff9e00a952ce2b--monaco-graphql.netlify.app

[changeset-bot]

🦋 Changeset detected

Latest commit: bb52471

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
graphql-language-service-interface	Patch
monaco-graphql	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[acao]

@rchl introducing more triggerCharacters here just to get it out of the way, what do you think? you can test with the monaco deploy preview

[acao]

so, this doesn't impact codemirror-graphql to be clear, because it doesn't use the command or insertText options we've added to the autocompletion

[rchl]

Sorry but to test this properly, I'd need this working in my editor. I'm not sure what to expect exactly from the codemirror behavior.

I'll check it out when it's out and report if I see any issues. :)

[acao]

@rchl you should expect the monaco demo to complete variables and trigger completion. Codemirror is not changed by this PR