Small bug when autocompleting variables

[bartenra]

Steps to Reproduce the Problem Or Description

Type

query ($test: String!) {
  hello (test: $[CURSOR HERE])
}

Press tab to autocomplete, select $test.

Expected Behavior

query ($test: String!) {
  hello (test: $test)
}

Actual Behavior

query ($test: String!) {
  hello (test: $$test)
}

Specifications

• GraphQL for VSCode Extension Version: v0.3.16
• VSCode Version: 1.56.2
• OS Name: Arch Linux
• OS Version: 2021.05.01

[acao]

Oof! I can fix this.

[acao]

thank you for this bug report!

I added support for variables completion last year, and thats where to fix some issues we had, i appended the $ character manually to the completion insertText for variable names. Oops! Will fix this!

[bartenra]

Awesome! 🎉

[acao]

graphiql/packages/graphql-language-service-interface/src/getAutocompleteSuggestions.ts

Line 604 in 503c376

label: `$${variableName}`,

and

graphiql/packages/graphql-language-service-interface/src/getAutocompleteSuggestions.ts

Line 609 in 503c376

definitions[variableName].insertText = `$${variableName}`;

are the offending lines

as a note for a PR, the insertText does not need to be passed at all if no transformation happens, just label is sufficient

[acao]

does this seem to fix the issue in this monaco example? from #2070
https://61a621696bff9e00a952ce2b--monaco-graphql.netlify.app/

quick way to demonstrate the universal LS features until we have a code-server deploy preview!