Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unsafe examples #157

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fixing unsafe examples #157

merged 1 commit into from
Jun 29, 2023

Conversation

mariomac
Copy link
Contributor

This PR corrects some unsafe examples leading to credentials being logged along with URLs.

@mariomac mariomac requested a review from grcevski as a code owner June 28, 2023 10:17
@codecov-commenter
Copy link

Codecov Report

Merging #157 (78bd47b) into main (ebb397a) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   76.82%   77.07%   +0.24%     
==========================================
  Files          33       33              
  Lines        2408     2408              
==========================================
+ Hits         1850     1856       +6     
+ Misses        416      411       -5     
+ Partials      142      141       -1     
Flag Coverage Δ
integration-test 77.07% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@mariomac mariomac merged commit 9e2a71b into grafana:main Jun 29, 2023
@mariomac mariomac deleted the fix-examples branch June 29, 2023 07:30
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants