Fixing unsafe examples (#157)

grafana · Jun 29, 2023 · 9e2a71b · 9e2a71b
1 parent c2befb7
commit 9e2a71b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/deployments/02-grafana-agent.yml b/deployments/02-grafana-agent.yml
@@ -27,7 +27,11 @@ data:
       
     prometheus.remote_write "mimir" {
       endpoint {
-        url = "https://" + env("MIMIR_USER") + ":" + env("GRAFANA_API_KEY") + "@" + env("MIMIR_ENDPOINT") + "/api/prom/push"
+        url = "https://" + env("MIMIR_ENDPOINT") + "/api/prom/push"
+        basic_auth {
+          username = env("MIMIR_USER")
+          password = env("GRAFANA_API_KEY")
+        }
       }
     }
       

diff --git a/docs/agent-vs-direct/README.md b/docs/agent-vs-direct/README.md
@@ -136,9 +136,13 @@ otelcol.exporter.prometheus "default" {
 }
     
 prometheus.remote_write "mimir" {
-    endpoint {
-        url = "https://" + env("MIMIR_USER") + ":" + env("GRAFANA_API_KEY") + "@" + env("MIMIR_ENDPOINT") + "/api/prom/push"
+  endpoint {
+    url = "https://" + env("MIMIR_ENDPOINT") + "/api/prom/push"
+    basic_auth {
+      username = env("MIMIR_USER")
+      password = env("GRAFANA_API_KEY")
     }
+  }
 }
 ```
 

diff --git a/docs/agent-vs-direct/agent-config.river b/docs/agent-vs-direct/agent-config.river
@@ -21,7 +21,11 @@ otelcol.exporter.prometheus "default" {
 
 prometheus.remote_write "mimir" {
     endpoint {
-        url = "https://" + env("MIMIR_USER") + ":" + env("GRAFANA_API_KEY") + "@" + env("MIMIR_ENDPOINT") + "/api/prom/push"
+        url = "https://" + env("MIMIR_ENDPOINT") + "/api/prom/push"
+        basic_auth {
+            username = env("MIMIR_USER")
+            password = env("GRAFANA_API_KEY")
+        }
     }
 }