-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ruby-enum
dependency
#140
Conversation
when Array | ||
option = [nil] if option.empty? | ||
raise TypeError if option.none? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dunno what error message should I put here, but existing option ':' does not exist for CommonMarker::Config::Render
looks wrong.
Overall I think that it could be just OPTS.fetch(type).fetch_values(*Array(option)).inject(0, :|)
and that's it.
Right now we're overly strict in accepted types (why Set.new([:DEFAULT])
cannot be passed?) and IMHO it's expected that []
will be counted as a use defaults
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points. Regarding being "overly strict"—I have a tendency to lean towards paranoia when interactions with C occur, hence the small whitelist of accepted types.
Sending to review due to |
Ugh, CI is failing due to
(rubocop dropped 2.4 support a while ago, so unfixable)
which is required and not redundant on 2.4. Also specs are failing for 2.4 locally ( |
Let's actually bring the constraint to 2.6, and remove 2.5 from CI. 2.5 is EOL and I don't want to support EOL Rubies. Thanks for bringing this up! |
2a2d1c4
to
414d228
Compare
Done, first commit bumps ruby to 2.6, second actually removing ruby-enum. And again |
Thank you for your contribution here, I really appreciate it. |
CommonMarker 0.22 removed the Parser class and breaks jekyll-commonmark gjtorikian/commonmarker#140
CommonMarker 0.22 removed the Parser class and breaks jekyll-commonmark gjtorikian/commonmarker#140
CommonMarker 0.22 removed the Parser class and breaks jekyll-commonmark gjtorikian/commonmarker#140
Fixes #135