Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to removing the ruby-enum dependency? #135

Closed
bryanp opened this issue Apr 2, 2021 · 2 comments · Fixed by #140
Closed

Open to removing the ruby-enum dependency? #135

bryanp opened this issue Apr 2, 2021 · 2 comments · Fixed by #140

Comments

@bryanp
Copy link

bryanp commented Apr 2, 2021

I'd like to propose removing the ruby-enum dependency as it unnecessarily increases the footprint of this gem. ruby-enum includes i18n as a dependency, which itself depends on concurrent-ruby. We appear to only use ruby-enum in the config objects and don't use much of the functionality it offers. I'd even be willing to do the work of replacing.

Is this a contribution you'd be interested in seeing?

@gjtorikian
Copy link
Owner

Yeah, that sounds good. 👍 Thanks!

ojab added a commit to ojab/commonmarker that referenced this issue Jun 13, 2021
ojab added a commit to ojab/commonmarker that referenced this issue Jun 13, 2021
ojab added a commit to ojab/commonmarker that referenced this issue Jun 13, 2021
ojab added a commit to ojab/commonmarker that referenced this issue Jun 18, 2021
ojab added a commit to ojab/commonmarker that referenced this issue Jun 18, 2021
ojab added a commit to ojab/commonmarker that referenced this issue Jun 18, 2021
ojab added a commit to ojab/commonmarker that referenced this issue Jun 20, 2021
@dblock
Copy link

dblock commented Feb 14, 2023

I've opened dblock/ruby-enum#41 to make the i18n dependency optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants