Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-row-select cell firing onClickRow twice #27010

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −16
Open

Fix multi-row-select cell firing onClickRow twice #27010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22eb7c2
Fix multi-row-select cell firing onClickRow twice
dantecatalfamo Mar 10, 2025
e554adb
Add changes/
dantecatalfamo Mar 10, 2025
dd8c048
If multirow select is enabled, don't call action on the first cell
dantecatalfamo Mar 11, 2025
ae3a0d1
Remove onclick from individual cells
dantecatalfamo Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/26564-multi-cell-select-twice
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed row selection firing twice in host selection screen
18 changes: 2 additions & 16 deletions frontend/components/TableContainer/DataTable/DataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,30 +583,16 @@
{row.cells.map((cell: any, index: number) => {
// Only allow row click behavior on first cell
// if the first cell is not a checkbox
const isFirstCell = index === 0;
const cellProps = cell.getCellProps();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RachelElysia, I'm testing these changes as Dante made them and tables seem to be working okay - still tab-able, enter checks and unchecks boxes, and I can click through for rows that have row-click functionality. The bug it targets for fixing is also fixed.

Since you wrote this pretty recently, can you clarify the intended behavior of these lines, and confirm that it's okay to remove them like this?

const multiRowSelectCell =
isFirstCell && !disableMultiRowSelect;

if (!multiRowSelectCell) {
cellProps.onClick = () => {
onClickRow && onClickRow(row);
};
cellProps.onKeyDown = (e: KeyboardEvent) => {
if (e.key === "Enter") {
onClickRow && onClickRow(row);
}
};
}
const multiRowSelectEnabled = !disableMultiRowSelect;

return (
<td
key={cell.column.id}
className={
cell.column.id ? `${cell.column.id}__cell` : ""
}
style={multiRowSelectCell ? { cursor: "initial" } : {}}
style={multiRowSelectEnabled ? { cursor: "initial" } : {}}

Check failure on line 595 in frontend/components/TableContainer/DataTable/DataTable.tsx

View workflow job for this annotation

GitHub Actions / lint-js (ubuntu-latest) 

Replace `multiRowSelectEnabled·?·{·cursor:·"initial"·}·:·{}` with `⏎··························multiRowSelectEnabled·?·{·cursor:·"initial"·}·:·{}⏎························`
{...cellProps}
>
{cell.render("Cell")}
Expand Down
Loading