-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-row-select cell firing onClickRow twice #27010
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27010 +/- ##
==========================================
- Coverage 63.99% 63.99% -0.01%
==========================================
Files 1704 1705 +1
Lines 162237 162231 -6
Branches 4274 4321 +47
==========================================
- Hits 103822 103818 -4
+ Misses 50346 50344 -2
Partials 8069 8069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think this might be fixed with @ghernandez345 's work on switching to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has some unintended consequences for regular row selectability
const cellProps = cell.getCellProps(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RachelElysia, I'm testing these changes as Dante made them and tables seem to be working okay - still tab-able, enter checks and unchecks boxes, and I can click through for rows that have row-click functionality. The bug it targets for fixing is also fixed.
Since you wrote this pretty recently, can you clarify the intended behavior of these lines, and confirm that it's okay to remove them like this?
#26564
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.