Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-row-select cell firing onClickRow twice #27010

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Mar 10, 2025

#26564

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

@dantecatalfamo dantecatalfamo marked this pull request as ready for review March 10, 2025 20:45
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner March 10, 2025 20:45
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.99%. Comparing base (3214328) to head (ae3a0d1).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27010      +/-   ##
==========================================
- Coverage   63.99%   63.99%   -0.01%     
==========================================
  Files        1704     1705       +1     
  Lines      162237   162231       -6     
  Branches     4274     4321      +47     
==========================================
- Hits       103822   103818       -4     
+ Misses      50346    50344       -2     
  Partials     8069     8069              
Flag Coverage Δ
frontend 54.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia
Copy link
Member

I think this might be fixed with @ghernandez345 's work on switching to enableMultiRowSelect? Either way, @ghernandez345 can you have eyes on this?

Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has some unintended consequences for regular row selectability

const cellProps = cell.getCellProps();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RachelElysia, I'm testing these changes as Dante made them and tables seem to be working okay - still tab-able, enter checks and unchecks boxes, and I can click through for rows that have row-click functionality. The bug it targets for fixing is also fixed.

Since you wrote this pretty recently, can you clarify the intended behavior of these lines, and confirm that it's okay to remove them like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants