Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image-viewer): 重构 image-viewer 组件 #259

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

ruige24601
Copy link
Contributor

@ruige24601 ruige24601 commented Jul 31, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(ImageViewer): 新增 maxZoom、closeBtn、onClose 属性

  • feat(ImageViewer): 新增 close 事件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2022

完成

@LeeJim
Copy link
Collaborator

LeeJim commented Aug 1, 2022

测试挂了,麻烦关注一下

@ruige24601
Copy link
Contributor Author

辛苦指导一下,如何解决这个问题吗?
我的企微: sskrgong

Copy link
Contributor

@Dengzygx Dengzygx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dengzygx Dengzygx merged commit 650f9d6 into Tencent:develop Aug 10, 2022
@LeeJim
Copy link
Collaborator

LeeJim commented Aug 12, 2022

下次合并前,记得关注下更新日志,不然发版的时候梳理 changelog 很麻烦

@github-actions github-actions bot mentioned this pull request Aug 15, 2022
@anlyyao anlyyao linked an issue Aug 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ImageViewer] API文档已更新,需补充所缺属性
3 participants