Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageViewer] API文档已更新,需补充所缺属性 #169

Closed
anlyyao opened this issue Jun 13, 2022 · 6 comments · Fixed by #259
Closed

[ImageViewer] API文档已更新,需补充所缺属性 #169

anlyyao opened this issue Jun 13, 2022 · 6 comments · Fixed by #259
Labels
enhancement New feature or request help wanted Extra attention is needed Stale

Comments

@anlyyao
Copy link
Collaborator

anlyyao commented Jun 13, 2022

tdesign-mobile-vue 版本

0.8.6

重现链接

https://github.com/Tencent/tdesign-mobile-vue/tree/feat/image-viewer/props

重现步骤

API差异

期望结果

实现propscloseBtndeleteBtnimagesindexshowIndextriggervisible

实现eventcloseindexChange

实际结果

目前propsimagesvisibleshowIndexinitialIndexbackgroundColor

目前eventchange

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

  1. API:feat/image-viewer/props分支下,ImageViewer组件的image-viewer.mdprops.tstype.ts为最新API文档及功能需求,需对齐该文档对ImageViewer组件进行重构。
  2. 开发:参照API文档,基于feat/image-viewer/props分支开发
@github-actions
Copy link
Contributor

👋 @anlyyao,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

♥️ 有劳 @dufemeng 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @anlyyao

@anlyyao anlyyao mentioned this issue Jun 16, 2022
58 tasks
@github-actions
Copy link
Contributor

这个 Issue 被标记为了过时 stale ,因为它已经持续 30 天没有任何活动了。删除 stale 标签或评论,否则将在 7 天内关闭。

@github-actions github-actions bot added the Stale label Jul 14, 2022
@LeeJim LeeJim added enhancement New feature or request help wanted Extra attention is needed and removed Stale labels Jul 14, 2022
@github-actions
Copy link
Contributor

任何人都可以处理此问题。
请务必在您的 pull request 中引用此问题。
感谢你的贡献! ✨

@github-actions
Copy link
Contributor

这个 Issue 被标记为了过时 stale ,因为它已经持续 30 天没有任何活动了。删除 stale 标签或评论,否则将在 7 天内关闭。

@github-actions github-actions bot added the Stale label Aug 14, 2022
@anlyyao anlyyao linked a pull request Aug 16, 2022 that will close this issue
16 tasks
@anlyyao
Copy link
Collaborator Author

anlyyao commented Aug 16, 2022

已完成。

@anlyyao anlyyao closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants