Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log extension messages at the INFO level #1551

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

neilmb
Copy link
Contributor

@neilmb neilmb commented Feb 18, 2025

The change to ckanext-geodatagov didn't stop our loud "Added FQ to collection_package_id" because we were logging ckanext at the DEBUG level in ckan.ini. This changes that file to log messages from extensions at the INFO level.

I pushed this manually to staging and it appears to have stopped the desired messages from making it to New Relic:

Screenshot 2025-02-18 at 3 01 42 PM

@neilmb neilmb requested review from FuhuXia and a team February 18, 2025 21:02
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably long overdue, although this will change the logging info for all ckan extensions across all catalog instances (including harvester). However we never should have had debug level logging on at all, so I believe this is good to merge.

@btylerburton btylerburton merged commit 91aee9b into main Feb 19, 2025
9 checks passed
@btylerburton btylerburton deleted the nmb/ckanext-log-level branch February 19, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants