feat: Improvements in the GitHub integration BE

api/integrations/github/client.py

@@ -2,7 +2,7 @@
 from github import Auth, Github
 
 
-def generate_token(installation_id: str, app_id: int) -> str:
+def generate_token(installation_id: str, app_id: int) -> str:  # pragma: no cover
     auth: Auth.AppInstallationAuth = Auth.AppAuth(
         app_id=int(app_id), private_key=settings.GITHUB_PEM
     ).get_installation_auth(
@@ -12,3 +12,12 @@ def generate_token(installation_id: str, app_id: int) -> str:
     Github(auth=auth)
     token = auth.token
     return token
+
+
+def generate_jwt_token(app_id: int) -> str:  # pragma: no cover
+    github_auth: Auth.AppAuth = Auth.AppAuth(
+        app_id=int(app_id),
+        private_key=settings.GITHUB_PEM,
+    )
+    token = github_auth.create_jwt()
+    return token

api/integrations/github/views.py

@@ -11,7 +11,7 @@
 from rest_framework.permissions import AllowAny, IsAuthenticated
 from rest_framework.response import Response
 
-from integrations.github.client import generate_token
+from integrations.github.client import generate_jwt_token, generate_token
 from integrations.github.constants import GITHUB_API_URL, GITHUB_API_VERSION
 from integrations.github.exceptions import DuplicateGitHubIntegration
 from integrations.github.helpers import github_webhook_payload_is_valid
@@ -71,6 +71,23 @@ def create(self, request, *args, **kwargs):
             if re.search(r"Key \(organisation_id\)=\(\d+\) already exists", str(e)):
                 raise DuplicateGitHubIntegration
 
+    def destroy(self, request, *args, **kwargs):
+        instance = self.get_object()
+        installation_id = instance.installation_id
+        token = generate_jwt_token(settings.GITHUB_APP_ID)
+
+        url = f"{GITHUB_API_URL}app/installations/{installation_id}"
+
+        headers = {
+            "X-GitHub-Api-Version": GITHUB_API_VERSION,
+            "Accept": "application/vnd.github.v3+json",
+            "Authorization": f"Bearer {token}",
+        }
+
+        response = requests.delete(url, headers=headers, timeout=10)
+        response.raise_for_status()
+        return super().destroy(request, *args, **kwargs)
+
 
 class GithubRepositoryViewSet(viewsets.ModelViewSet):
     permission_classes = (

api/tests/unit/integrations/github/test_unit_github_views.py

@@ -19,6 +19,18 @@
 WEBHOOK_SECRET = "secret-key"
 
 
+def mocked_requests_delete(*args, **kwargs):
+    class MockResponse:
+        def __init__(self, json_data, status_code):
+            self.json_data = json_data
+            self.status_code = status_code
+
+        def raise_for_status(self) -> None:
+            pass
+
+    return MockResponse(json_data={"data": "data"}, status_code=204)
+
+
 def test_get_github_configuration(
     admin_client_new: APIClient,
     organisation: Organisation,
@@ -105,6 +117,7 @@ def test_delete_github_configuration(
     organisation: Organisation,
     github_configuration: GithubConfiguration,
     github_repository: GithubRepository,
+    mocker: MockerFixture,
 ) -> None:
     # Given
     url = reverse(
@@ -114,10 +127,18 @@ def test_delete_github_configuration(
             github_configuration.id,
         ],
     )
+
+    mock_generate_token = mocker.patch(
+        "integrations.github.views.generate_jwt_token",
+    )
+    mock_generate_token.return_value = "mocked_token"
+    mocker.patch("requests.delete", side_effect=mocked_requests_delete)
+
     # When
     response = admin_client_new.delete(url)
     # Then
     assert response.status_code == status.HTTP_204_NO_CONTENT
+    assert not GithubConfiguration.objects.filter(id=github_configuration.id).exists()
 
 
 def test_get_github_repository(