feat: Improvements in the GitHub integration BE #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3962 +/- ##
==========================================
+ Coverage 96.22% 96.28% +0.06%
==========================================
Files 1142 1143 +1
Lines 36775 36992 +217
==========================================
+ Hits 35386 35618 +232
+ Misses 1389 1374 -15 ☔ View full report in Codecov by Sentry. |
novakzaballa
requested review from
a team and
khvn26
and removed request for
a team
khvn26
reviewed
May 16, 2024
khvn26
reviewed
May 16, 2024
khvn26
reviewed
May 16, 2024
khvn26
reviewed
May 16, 2024
khvn26
reviewed
May 16, 2024
khvn26
reviewed
May 16, 2024
khvn26
reviewed
May 16, 2024
api/integrations/github/views.py
Outdated
| } | ||
|
|
||
| response = requests.delete(url, headers=headers, timeout=10) | ||
| response.raise_for_status() |
There was a problem hiding this comment.
We're assuming we're returning 500 in case of any errors from Github here?
Do we want to return the error message to the client or at least log it in some way?
There was a problem hiding this comment.
Right, good catch. Done.
khvn26
requested changes
May 16, 2024
|
Flagsmith feature linked:
Segment
|
|
Flagsmith Feature
|
The feature flag
|
khvn26
reviewed
May 22, 2024
api/integrations/github/views.py
Outdated
| try: | ||
| return func(*args, **kwargs) | ||
| except requests.RequestException as e: | ||
| logger.error(f"{error or default_error} Error: {str(e)}") |
There was a problem hiding this comment.
Suggested change
| logger.error(f"{error or default_error} Error: {str(e)}") | |
| logger.error(f"{error or default_error} Error: {str(e)}", exc_info=e) |
khvn26
approved these changes
May 22, 2024
novakzaballa
deleted the
feat/uninstall-github-app-installation-from-flagsmith
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
/app/installations/{installation_id}integration/github/client.pyfile.How did you test this code?