fix(feature-service/get_edge_override): handle deleted features #3368
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
bot
temporarily deployed
to
Preview – flagsmith-frontend-staging
gagantrivedi
force-pushed
the
fix-v2-overrides
branch
from
35c3642 to
04d2513
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
===========================================
- Coverage 95.93% 27.39% -68.54%
===========================================
Files 1071 993 -78
Lines 32755 28598 -4157
===========================================
- Hits 31423 7834 -23589
- Misses 1332 20764 +19432 ☔ View full report in Codecov by Sentry. |
|
Uffizzi Preview |
| edge_identity.add_feature_override( | ||
| map_feature_state_to_engine(identity_featurestate), | ||
| ) | ||
| edge_identity.add_feature_override( | ||
| map_feature_state_to_engine(distinct_identity_featurestate), | ||
| ) |
There was a problem hiding this comment.
Perhaps we can discuss this on the standup but I'm a little unsure on the details here. Are these overrides for 2 different features?
It's not obvious to me from the test why we're still left with one edge identity override.
There was a problem hiding this comment.
Yeah, that's for a different feature
There was a problem hiding this comment.
I think some comments would probably help here.
# Let's add 2 overrides for 2 separate features for the edge identity
edge_identity.add_feature_override(
...
# and delete one of the features
feature.delete()
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes this by skipping deleted features when calculating overrides for edge
How did you test this code?
Adds unit test