fix(feature-service/get_edge_override): handle deleted features #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3367 +/- ##
===========================================
- Coverage 95.93% 27.39% -68.54%
===========================================
Files 1071 993 -78
Lines 32755 28598 -4157
===========================================
- Hits 31423 7834 -23589
- Misses 1332 20764 +19432 ☔ View full report in Codecov by Sentry. |
|
Uffizzi Preview |
gagantrivedi
force-pushed
the
fix/v2-overrides
branch
from
46d26dc to
4ac94f2
Compare
gagantrivedi
had a problem deploying
to
staging
GitHub Actions
Failure
vercel
bot
temporarily deployed
to
Preview – flagsmith-frontend-staging
|
closing for #3368 |
vercel
bot
temporarily deployed
to
Preview – flagsmith-frontend-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes this by skipping deleted features when calculating overrides for edge
How did you test this code?
Adds unit test