Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust segment not rule #3267

Merged
merged 4 commits into from
Jan 11, 2024
Merged

fix: Adjust segment not rule #3267

merged 4 commits into from
Jan 11, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 10, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Note: this feature is controlled via the segment_operator flag.

  • Adjusts the not condition to send the right payload to the API
  • Adjusts UI to distinguish between AND and AND NOT conditions

image

How did you test this code?

  • Created the above segment in production, viewed a user and added a trait that matches one of the rules. The user as a result was no longer part of the segment.

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:35am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:35am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:35am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 10, 2024
@kyle-ssg kyle-ssg changed the title Adjust segment not rule chore: Adjust segment not rule Jan 10, 2024
@kyle-ssg kyle-ssg changed the title chore: Adjust segment not rule fix: Adjust segment not rule Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Uffizzi Preview deployment-44102 was deleted.

novakzaballa
novakzaballa approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2024-01-10 at 16 26 21

LGTM, just one thing, by removing the first condition and adding another one, the text is incorrect.

@kyle-ssg
Copy link
Member Author

Fixed

@kyle-ssg kyle-ssg added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit 6edc932 Jan 11, 2024
@kyle-ssg kyle-ssg deleted the fix/adjust-segment-not-rule branch January 11, 2024 10:34
@kyle-ssg kyle-ssg linked an issue Jan 11, 2024 that may be closed by this pull request
Add "Not" predicate operator in the Segment rules #382
Closed
@dabeeeenster dabeeeenster mentioned this pull request Jan 11, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@dabeeeenster dabeeeenster Awaiting requested review from dabeeeenster

@khvn26 khvn26 Awaiting requested review from khvn26

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Not" predicate operator in the Segment rules
2 participants
@kyle-ssg @novakzaballa