Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Not" predicate operator in the Segment rules #382

Closed
dabeeeenster opened this issue Oct 1, 2021 · 7 comments · Fixed by #3267
Closed

Add "Not" predicate operator in the Segment rules #382

dabeeeenster opened this issue Oct 1, 2021 · 7 comments · Fixed by #3267
Assignees
Labels
api Issue related to the REST API feature New feature or request

Comments

@dabeeeenster
Copy link
Contributor

dabeeeenster commented Oct 1, 2021

We should have an "Add AND NOT" as per below:

image

Would also mean updating https://github.com/Flagsmith/flagsmith-engine

@dabeeeenster dabeeeenster added api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard labels Oct 1, 2021
@kyle-ssg
Copy link
Member

kyle-ssg commented Dec 4, 2021

Added frontend under flag "not_operator", presumed format would be type:"NOT". The flag allows for adding an array of supported clientside evaluation SDKs (see staging for an example, leaving empty will remove the tooltip).

[
  {
    "type": "ALL",
    "rules": [
      {
        "type": "ANY",
        "rules": [],
        "conditions": [
          {
            "operator": "EQUAL",
            "property": "test",
            "value": "test"
          }
        ]
      },
      {
        "type": "NOT",
        "conditions": [
          {
            "property": "test",
            "operator": "EQUAL",
            "value": "test2"
          }
        ]
      }
    ],
    "conditions": []
  }
]

@khvn26
Copy link
Member

khvn26 commented Jan 10, 2024

As discussed internaly, the proposed operator should actually be "NONE" (and is already supported by engine implementations).

@kyle-ssg
Copy link
Member

This is now available under the not_operator flag, I've tested my end and users do seem to be correctly assigned to segments based on the rules.

@Dogacel
Copy link
Contributor

Dogacel commented Feb 14, 2024

Hi, is the frontend of and not still being implemented? I am not able to see the and not button in our on-prem setup.

@dabeeeenster
Copy link
Contributor Author

Heads up @kyle-ssg ?

@kyle-ssg
Copy link
Member

This is now available under the not_operator flag, I've tested my end and users do seem to be correctly assigned to segments based on the rules.

This @dabeeeenster, we need to simply turn on the not_operator feature for self hosted defaults if we're happy with it.

@dabeeeenster
Copy link
Contributor Author

OK! NOT operator is live for self hosted installs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants