fix: ensure SimpleFeatureStateViewSet uses correct permissions for segment overrides #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
zachaysan
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
+ Coverage 95.56% 95.58% +0.01%
==========================================
Files 1014 1016 +2
Lines 29421 29526 +105
==========================================
+ Hits 28116 28222 +106
+ Misses 1305 1304 -1 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
Nov 17, 2023
|
|
||
| def test_create_segment_override__using_simple_feature_state_viewset__allows_manage_segment_overrides( | ||
| staff_client: APIClient, | ||
| with_environment_permissions: Callable[[list[str], int], None], |
There was a problem hiding this comment.
Suggested change
| with_environment_permissions: Callable[[list[str], int], None], | |
| with_environment_permissions: Callable[[list[str]], None], |
Not precisely accurate but correct
There was a problem hiding this comment.
Well, technically, I guess it should be Callable[[list[str], int | None], None] based on the definition:
@pytest.fixture()
def with_environment_permissions(
environment: Environment, staff_user: FFAdminUser
) -> typing.Callable[[list[str], int], None]:
"""
Add environment permissions to the staff_user fixture.
Defaults to associating to the environment fixture.
"""
def _with_environment_permissions(
permission_keys: list[str], environment_id: typing.Optional[int] = None
) -> UserEnvironmentPermission:
environment_id = environment_id or environment.id
uep, __ = UserEnvironmentPermission.objects.get_or_create(
environment_id=environment_id, user=staff_user
)
uep.permissions.add(*permission_keys)
return uep
return _with_environment_permissions
khvn26
approved these changes
Nov 17, 2023
matthewelwell
deleted the
fix/segment-overrides-via-simple-feature-state-viewset
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Fixes an issue found when testing the new MANAGE_SEGMENTS permission functionality. The FE uses the SimpleFeatureStateViewSet for updating segment overrides, which the new permission didn't cover. This PR ensures that this endpoint is correctly covered by the new permission for creating (although this is not used by the FE) and updating segment overrides via this API route.
How did you test this code?
Added new unit tests.