chore: improve UPDATE_FEATURE_STATE permission in UI #2986
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
novakzaballa
requested review from
a team and
kyle-ssg
and removed request for
a team
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
Looks like there's something on the API preventing it still @zachaysan |
|
I've fixed the above in #2990. There is one minor FE tweak that I've noticed which would be good to resolve which is that the tooltip which comes up on hover on the feature row is kind of misleading now. 
I have a feeling this has been misleading since we allowed users to view the feature slide out, but it's a good time to resolve it here I think @novakzaballa. I think we can just remove the tooltip altogether here. |
|
I've removed the tooltip here |
matthewelwell
dismissed
their stale review
Changes should be wrapped in the relevant feature flag.
| <Permission | ||
| level='environment' | ||
| permission={Utils.getManageFeaturePermission( | ||
| is4Eyes, | ||
| identity, | ||
| )} | ||
| id={this.props.environmentId} | ||
| > | ||
| {({ | ||
| permission: savePermission, | ||
| }) => ( | ||
| <Permission | ||
| level='environment' | ||
| permission={ | ||
| 'MANAGE_SEGMENT_OVERRIDES' | ||
| } | ||
| id={ | ||
| this.props.environmentId | ||
| } | ||
| > | ||
| {({ | ||
| permission: | ||
| manageSegmentsOverrides, | ||
| }) => { |
There was a problem hiding this comment.
I don't quite understand what this code is doing but I have tested it functionally and it seems to behave how I expect!
novakzaballa
deleted the
chore/improve-update-feature-state-permission-in-ui
branch
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
How did you test this code?