-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): add support for Amplitude base url #2534
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
=======================================
Coverage 95.43% 95.44%
=======================================
Files 972 974 +2
Lines 27191 27207 +16
=======================================
+ Hits 25951 25967 +16
Misses 1240 1240
☔ View full report in Codecov by Sentry. |
429c9fe
to
6d7c097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this comment as a reminder to update Edge API too.
Yep, good point @khvn26. Edge PR is here: #2534 (review). |
Changes
Adds support for
base_url
attribute in theAmplitudeConfiguration
model.Fixes #2522
NOTE: we will also need to update the
integration_data
flag to expose this in the UI.How did you test this code?
Added unit test. I've also tested this manually to verify that with the new default url (api2.amplitude.com) events are still ingested correctly.