Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base URL to Amplitude integration #2522

Closed
khvn26 opened this issue Jul 26, 2023 · 0 comments · Fixed by #2534
Closed

Add Base URL to Amplitude integration #2522

khvn26 opened this issue Jul 26, 2023 · 0 comments · Fixed by #2534
Assignees

Comments

@khvn26
Copy link
Member

khvn26 commented Jul 26, 2023

Is your feature request related to a problem? Please describe.

Amplitude clients with EU data residency now need to call a separate base URL.
As per the docs:

For EU data residency, the project must be set up inside Amplitude EU. Replace the standard endpoint https://api2.amplitude.com/2/httpapi with the EU residency endpoint https://api.eu.amplitude.com/2/httpapi in all examples to ensure proper data residency.

Flagsmith currently hard-codes the Amplitude base URL.

Describe the solution you'd like

  1. Expose the Base URL field in the integration create UI.
  2. Migrate existing Amplitude integrations to store the default base URL in the configuration model.
  3. Update the Core and Edge integration code to use the stored base URL.

Describe alternatives you've considered

N/A

Additional context

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants