Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Combine segment override and value change requests #4734

Merged

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes an invalid response from associated segment overrides

How did you test this code?

Manually checked that a null value for segment overrides does not cause the error when it previously did

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 16, 2024 10:22
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4734 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4734 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4734 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4734 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4734 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4734 Finished ✅ Results

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 10:23am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 10:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 16, 2024 10:23am

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Uffizzi Ephemeral Environment deployment-57305

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4734

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 714a68b Oct 16, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the fix/handle-invalid-associated-segment-override-response branch October 16, 2024 10:28
Copy link
Contributor

Uffizzi Preview deployment-57305 was deleted.

matthewelwell pushed a commit that referenced this pull request Oct 16, 2024
matthewelwell pushed a commit that referenced this pull request Oct 16, 2024
matthewelwell pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants