Skip to content

Commit 6083a41

Browse files
kyle-ssgmatthewelwell
authored andcommitted
fix: Combine segment override and value change requests (#4734)
(cherry picked from commit 714a68b)
1 parent 4278d59 commit 6083a41

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

frontend/web/components/modals/AssociatedSegmentOverrides.js

+5-8
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,7 @@ class TheComponent extends Component {
177177
}
178178
renderRow={(v) => (
179179
<div key={v.feature.id} className='list-item-override p-3 mb-4'>
180-
<div
181-
onClick={() => {
182-
// window.open(`${document.location.origin}/project/${this.props.projectId}/environment/${v.env.api_key}/features?feature=${v.feature.id}&tab=1`)
183-
}}
184-
>
180+
<div>
185181
<WrappedSegmentOverrides
186182
onSave={this.fetch}
187183
projectFlag={v.feature}
@@ -331,9 +327,10 @@ export default class SegmentOverridesInner extends Component {
331327
)
332328
this.setState({ isSaving: true })
333329
})
334-
const segmentOverride =
335-
segmentOverrides && segmentOverrides.filter((v) => v.segment === id)
336-
if (!segmentOverrides) return null
330+
const segmentOverride = segmentOverrides?.filter?.(
331+
(v) => v.segment === id,
332+
)
333+
if (!segmentOverride?.length) return null
337334
return (
338335
<div>
339336
{originalSegmentOverrides.length > 1 && (

0 commit comments

Comments
 (0)