fix: Combine segment override and value change requests (#4734)

Flagsmith · Oct 16, 2024 · 714a68b · 714a68b
1 parent 324fe12
commit 714a68b
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/frontend/web/components/modals/AssociatedSegmentOverrides.js b/frontend/web/components/modals/AssociatedSegmentOverrides.js
@@ -177,11 +177,7 @@ class TheComponent extends Component {
             }
             renderRow={(v) => (
               <div key={v.feature.id} className='list-item-override p-3 mb-4'>
-                <div
-                  onClick={() => {
-                    // window.open(`${document.location.origin}/project/${this.props.projectId}/environment/${v.env.api_key}/features?feature=${v.feature.id}&tab=1`)
-                  }}
-                >
+                <div>
                   <WrappedSegmentOverrides
                     onSave={this.fetch}
                     projectFlag={v.feature}
@@ -331,9 +327,10 @@ export default class SegmentOverridesInner extends Component {
               )
             this.setState({ isSaving: true })
           })
-          const segmentOverride =
-            segmentOverrides && segmentOverrides.filter((v) => v.segment === id)
-          if (!segmentOverrides) return null
+          const segmentOverride = segmentOverrides?.filter?.(
+            (v) => v.segment === id,
+          )
+          if (!segmentOverride?.length) return null
           return (
             <div>
               {originalSegmentOverrides.length > 1 && (