Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice recording feature (Issue #1953) #1963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gyan-max
Copy link

@Gyan-max Gyan-max commented Mar 8, 2025

Title: Add Voice Recording Feature
/claim #1953

Description:

This pull request implements the voice recording feature for the Omi application, allowing users to record audio directly using their device's microphone. The following changes have been made:

  1. VoiceRecordingPage:

    • Created a new page for recording audio with a user-friendly interface.
    • Includes a timer display, recording status indicator, and start/stop controls.
    • Handles microphone permissions to ensure proper access.
  2. CaptureProvider Updates:

    • Added the processPhoneRecording method to handle audio files recorded with the phone.
    • Implemented helper methods for creating and finalizing conversations with phone recordings.
    • Sends recorded audio to the server for transcription via WebSocket.
  3. Conversation Schema:

    • Updated the ConversationSource enum to include a new source type: phone.
    • Modified the getTag() method to display "Phone Recording" for conversations recorded with the phone.
  4. UI Access Point:

    • Added a floating action button on the home page for quick access to the voice recording feature.
    • The button is visually distinct with a red color and microphone icon.

Testing:

  • The feature has been tested on both Android and iOS emulators.
  • Verified that recordings are processed correctly and appear in the conversation list with the appropriate tag.
  • Handled edge cases, including permission denial and short recordings.

Related Issue: #1953

Implemented voice recording using the device's microphone with the following changes: Created VoiceRecordingPage for recording audio; Added processPhoneRecording method to CaptureProvider; Added 'phone' source type to ConversationSource enum; Added microphone button to the home page
@beastoin
Copy link
Collaborator

beastoin commented Mar 9, 2025

@Gyan-max man, please clarify the requirement before starting implement the feature. e.g. voice recording for what ?

and, share your test/demo before requesting for review :)

/ draft

@beastoin beastoin marked this pull request as draft March 9, 2025 01:29
@Gyan-max Gyan-max marked this pull request as ready for review March 9, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants