Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record with voice #1953

Open
kodjima33 opened this issue Mar 5, 2025 · 4 comments
Open

record with voice #1953

kodjima33 opened this issue Mar 5, 2025 · 4 comments
Labels

Comments

@kodjima33
Copy link
Collaborator

kodjima33 commented Mar 5, 2025

This feature is just too good not to be added

As soon as our consumer device is delivered, we can disable it

Image

/bounty $100

Copy link

algora-pbc bot commented Mar 5, 2025

💎 $100 bounty • omi

Steps to solve:

  1. Start working: Comment /attempt #1953 with your implementation plan
  2. Submit work: Create a pull request including /claim #1953 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to BasedHardware/omi!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @Gyan-max Mar 8, 2025, 1:45:55 PM #1963

@kodjima33 kodjima33 added good first issue Good for newcomers and removed 💎 Bounty labels Mar 5, 2025
@kotesh-arya
Copy link

@kodjima33 @algora-pbc
I’d like to work on this issue and wanted to clarify a few things:

  1. Is the bounty for this issue still open?
  2. What exactly does "disable the consumer device" mean?
    • Should the device be permanently disabled, or should it be reversible?
    • Is there an API endpoint or function already handling device activation that we should modify?
    • Does disabling mean preventing further usage, turning off remotely, or something else?

Looking forward to your response. Thanks!

@Gyan-max
Copy link

Gyan-max commented Mar 8, 2025

/claim #1953
The user is asking for a brief implementation plan for the GitHub issue #1953: "record with voice" feature. Based on the files I've been shown and the prior conversation, I can see that we've already implemented much of this feature.

Here's what we've implemented so far:

  1. Created a new VoiceRecordingPage for recording audio with the phone's microphone
  2. Added methods to the CaptureProvider to process phone recordings
  3. Added a 'phone' source type to the ConversationSource enum
  4. Updated the getTag() method to display "Phone Recording" for phone-recorded conversations
  5. Added a floating action button to the home page to access the voice recording feature

My implementation plan should summarize these steps and outline what else needs to be done to complete this feature.# Implementation Plan: Voice Recording Feature

Here's my plan to implement the voice recording feature (Issue #1953):

  1. Create VoiceRecordingPage

    • Create a new page with UI for recording audio using the phone's microphone
    • Include timer display, recording status indicator, and start/stop controls
    • Implement permissions handling for microphone access
  2. Update CaptureProvider

    • Add processPhoneRecording method to handle audio files recorded with the phone
    • Implement helper methods for creating and finalizing conversations with phone recordings
    • Send recorded audio to the server for transcription via WebSocket
  3. Update Conversation Schema

    • Add 'phone' to the ConversationSource enum to distinguish phone recordings
    • Update getTag() method to display "Phone Recording" for phone-recorded conversations
  4. Add UI Access Point

    • Add a floating action button to the home page for quick access to voice recording
    • Use red color and microphone icon to make it visually distinct
  5. Integration Testing

    • Test the complete flow from recording to transcription to conversation display
    • Verify proper error handling for permissions and audio processing
    • Confirm recordings are properly categorized as "Phone Recording" in the UI

This implementation makes recording directly with the phone easy and intuitive, while reusing the existing backend infrastructure for transcription and conversation management.

Gyan-max added a commit to Gyan-max/omi that referenced this issue Mar 8, 2025
Implemented voice recording using the device's microphone with the following changes: Created VoiceRecordingPage for recording audio; Added processPhoneRecording method to CaptureProvider; Added 'phone' source type to ConversationSource enum; Added microphone button to the home page
Copy link

algora-pbc bot commented Mar 8, 2025

💡 @Gyan-max submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants